-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust implementation of CDI #150
Comments
also @klihub |
If we're sure there is a need for this (and volunteers to do the Rust work) then I have no objections. |
@klihub I can at least speak from the Kata Containers' perspective, and we need it and we're going to do the Rust work ( mostly me :) |
Do we need a new repo for that or just maintain everything in this repo? |
@mythi I do not have any preference, but I think it would be easier to handle Issues/PRs if they are different projects. |
Any idea how to move this forward, how we should manage the added code now that we're under |
@zvonkok I think there are 2 possibilities to move forward quickly:
WDYT @elezar ? |
Sorry for the late response I was on PTO. @zvonkok a question to you: Would this repo only contain the rust implementation of the SPEC or all of the logic in the Assuming that the injection logic is the target, I think that starting with a I'm not against sponsoring a new repo, but think that having it in place already and moving it later probably reduces the friction significantly. Note, if it's only the spec that we're inerested in, then adding a folder:
to the existing repo may be sufficient. It may make some sense to split out the spec and the implementation at some point anyway. |
Got it, doing a POC first with Kata, and when stabilized we can move over to CNCF tags! |
Keeping this open for tracking, if you don't mind :) |
This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed. |
This issue was automatically closed due to inactivity. |
I started a discussion on the CNCF Slack: https://cloud-native.slack.com/archives/CPBE97SMU/p1722350144082649 |
@elezar @zvonkok I work on the CNCF Projects / Dev Rel Team One of the things we do on CNCF GitHub Orgs is manage access to repos. I would suggest that you create a new repo in the cncf-tags org. We use a tool called CLOWarden (implemented for the most part using Rust) which is a suite of components that provide us with a git-ops workflow for creating and managing access to the repos in CNCF GitHub orgs such as cncf-tags. If you want to add a repo to cncf-tags head over to the cncf-tags/org-admin repo and follow the instructions there in the README. |
Can it be hosted in this repo? Or we can create a separate repo under this org. wdyt? |
Whatever makes sense for the project and the maintainers of both sets of code. I'd offer the following points to consider in making the co-locate/new repo decision. Contributor Colaboration Code organization and discoverability Release cadence, release versioning Other considerations to include would be design, testing, CI and documentation. Whatever y'all decide we can support you either way. |
I would suggest to have a separate repository we do not want to intermingle Rust/go development. |
This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
@zvonkok I believe that this can be closed, correct? |
Closing we're live on https://github.com/cncf-tags/container-device-interface-rs |
Existing and upcoming projects are using Rust as the language of choice.
While the outer-runtime in Kata is written in go the inner runtime (kata-agent) is implemented in Rust.
We use CDI in the outer-runtime but the next step is to enable it in the inner-runtime as well.
Proposal to add a
container-device-interface-rust
repository to add a Rust implementation.The text was updated successfully, but these errors were encountered: