Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better cargo doc check into CI #14

Open
connortsui20 opened this issue Jan 29, 2025 · 0 comments
Open

Add better cargo doc check into CI #14

connortsui20 opened this issue Jan 29, 2025 · 0 comments
Assignees

Comments

@connortsui20
Copy link
Member

The cargo rustdoc check is causing a lot of problems, so we should find a better solution for that in CI (that is preferably simpler).

@connortsui20 connortsui20 self-assigned this Jan 29, 2025
@connortsui20 connortsui20 mentioned this issue Jan 29, 2025
AlSchlo added a commit that referenced this issue Jan 29, 2025
This PR models almost all of the types that will be necessary for
optimization. This includes:

- generic relational algebra operators that allow us to use the same
"type" for both expressions in the memo table and operators in the plans
- logical / physical plans
- scalar operators and expressions
- partially materialized logical plans for rule binding
- transformation rule + implementation rule trait and some empty structs
that implement them

I've named the crate itself `optd-core`. This can be subject to change,
but I feel this is a reasonable default for now.

~~TODO: need to wait on #3 and #12 to be merged before proper CI checks
can happen~~

Edit: I removed the `cargo rustdoc` check because its creating more
problem than it would solve, see #14

---------

Co-authored-by: Alexis Schlomer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant