Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question for implementing recovery #778

Open
loloxwg opened this issue Nov 27, 2024 · 0 comments
Open

Question for implementing recovery #778

loloxwg opened this issue Nov 27, 2024 · 0 comments

Comments

@loloxwg
Copy link

loloxwg commented Nov 27, 2024

The Bustub instance does not seem to utilize log recovery. There is no initialization of a flush thread, and upon system startup, there are no actions related to undo or redo operations.
Additionally, the current implementation of table_page.cpp does not include any checks for if (enable_logging).
It seems that in a certain commit, there was a comment like this:

/**
 * Removed to support new lock manager API for p4 (multilevel locking); Big hack energy
 * This clause was used in logging and recovery projects previously; not being used right now
 */

Why was it removed? It seems that log_manager->AppendLogRecord is not working now.
For building a disk oriented db, recovery is important part, I think the recovery should be a part of project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant