Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to configure the timeout of "Unconnected Send" messages #67

Open
gfcittolin opened this issue Mar 26, 2020 · 1 comment
Open

Comments

@gfcittolin
Copy link

When building an "Unconnected Send" message, there's no way of controlling the value of the timeout parameter. The function defaults to 2000ms, but the call doesn't allow us to customize it

Current Behavior

Currently, all connected messages are send with the fixed timeout of 2000 ms

Expected Behavior

The library user should be able to set other values to it

Possible Solution (Optional)

We could add a new constructor option that would control the timeout value, and defaulting it to the current 2000ms value

Context

We'd like to make node-red-contrib-cip-ethernet-ip (and therefore this library too) compatible with Omron controllers. There's even an issue there about it.

Last week, a very nice guy at Omron have done some tests and have identified that Omron controllers need this value to be at least 5024ms. So, if we can make this value configurable, we could add support to Omron controllers as well.

@gfcittolin
Copy link
Author

I'm preparing a simple PR adding this support for this with the above proposed solution, but we can still further discuss it if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant