Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Length failing to return on Tag Group #48

Open
balex3 opened this issue Jan 29, 2019 · 0 comments
Open

Length failing to return on Tag Group #48

balex3 opened this issue Jan 29, 2019 · 0 comments

Comments

@balex3
Copy link

balex3 commented Jan 29, 2019

.length() is not returning the number of groups within tag

Current Behavior

As above (node-ethernet-ip/src/tag-group/index.js)

Expected Behavior

Length of group should be returned

Possible Solution (Optional)

Change (Line 31) return Object.keys(this.tags).length; to return Object.keys(this.state.tags).length;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@balex3