Skip to content

Commit d747509

Browse files
committed
Switch from triplet only tracks to all tracks, to avoid problems with tracking particles (and b/c it makes more sense)
1 parent 214ab73 commit d747509

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

Validation/RecoHI/plugins/HitPixelLayersTPSelector.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class HitPixelLayersTPSelector
9696
std::vector<bool> pixelHitPattern( const TrackingParticleRef& simTrack, const TrackerTopology *tTopo )
9797
{
9898
std::vector<bool> hitpattern(5,false); // PXB 0,1,2 PXF 0,1
99-
99+
/*
100100
#warning "This file has been modified just to get it to compile without any regard as to whether it still functions as intended"
101101
#ifdef REMOVED_JUST_TO_GET_IT_TO_COMPILE__THIS_CODE_NEEDS_TO_BE_CHECKED
102102
for(std::vector<PSimHit>::const_iterator simHit = simTrack->pSimHit_begin();simHit!= simTrack->pSimHit_end();simHit++){
@@ -114,7 +114,9 @@ class HitPixelLayersTPSelector
114114
115115
}// end simhit loop
116116
#endif
117-
117+
*/
118+
// Indeed this no longer functions as intended, but this code should no longer be accessed, since tripletSeedOnly_ has been changed to False. We will clean up when we figure out how to do this properly - Matt Nguyen, 24/7/2013
119+
118120
return hitpattern;
119121
}
120122

Validation/RecoHI/python/TrackValidationHeavyIons_cff.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
# setup multi-track validator
2525
from Validation.RecoTrack.MultiTrackValidator_cff import *
2626
hiTrackValidator = multiTrackValidator.clone(
27-
label_tp_effic = cms.InputTag("findableSimTracks"),
27+
label_tp_effic = cms.InputTag("primaryChgSimTracks"),
2828
label_tp_fake = cms.InputTag("cutsTPFake"),
2929
signalOnlyTP = cms.bool(False),
3030
skipHistoFit = cms.untracked.bool(True), # done in post-processing
@@ -40,11 +40,11 @@
4040

4141
# track prevalidation
4242
hiTrackPrevalidation = cms.Sequence(
43-
findableSimTracks
44-
* cutsTPFake
45-
* cutsRecoTracks
46-
* cutsRecoTracksHP
47-
)
43+
primaryChgSimTracks
44+
* cutsTPFake
45+
* cutsRecoTracks
46+
* cutsRecoTracksHP
47+
)
4848

4949
# track validation sequence
5050
hiTrackValidation = cms.Sequence( hiTrackValidator )

Validation/RecoHI/python/selectSimTracks_cff.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import FWCore.ParameterSet.Config as cms
22

3+
# Not actually functioning at the moment, use primaryChgSimTracks - Matt Nguyen, 24/7/2013
34
findableSimTracks = cms.EDFilter("HitPixelLayersTPSelection",
45
src = cms.InputTag("mix","MergedTrackTruth"),
56
tripletSeedOnly = cms.bool(True),

0 commit comments

Comments
 (0)