clang-tidy changes

Dr15Jones · Dr15Jones · commit f1d9dc965d14 · 2025-04-23T15:00:29.000-05:00
diff --git a/FWCore/Framework/interface/EDConsumerBase.h b/FWCore/Framework/interface/EDConsumerBase.h
@@ -39,6 +39,7 @@
 #include "FWCore/Framework/interface/data_default_record_trait.h"
 #include "FWCore/Framework/interface/ModuleConsumesMinimalESInfo.h"
 #include "FWCore/ServiceRegistry/interface/ServiceRegistryfwd.h"
+#include "FWCore/ServiceRegistry/interface/ModuleConsumesInfo.h"
 #include "FWCore/Utilities/interface/BranchType.h"
 #include "FWCore/Utilities/interface/ESIndices.h"
 #include "FWCore/Utilities/interface/TypeID.h"
diff --git a/FWCore/Framework/src/PathsAndConsumesOfModules.cc b/FWCore/Framework/src/PathsAndConsumesOfModules.cc
@@ -507,7 +507,7 @@ namespace edm {
           }
         }
       }
-      result.emplace_back(std::move(info));
+      result.emplace_back(info);
     };
     return result;
   }
diff --git a/FWCore/TestProcessor/src/EventSetupTestHelper.cc b/FWCore/TestProcessor/src/EventSetupTestHelper.cc
@@ -75,6 +75,7 @@ namespace edm {
 
     std::vector<eventsetup::ESModuleProducesInfo> EventSetupTestHelper::producesInfo() const {
       std::vector<eventsetup::ESModuleProducesInfo> producesInfo;
+      producesInfo.reserve(resolvers_.size());
       for (auto const& p : resolvers_) {
         producesInfo.emplace_back(p.recordKey_, p.dataKey_, p.resolver_->produceMethodID());
       }

Original file line number	Diff line number	Diff line change
`@@ -507,7 +507,7 @@ namespace edm {`
`507`	`507`	`}`
`508`	`508`	`}`
`509`	`509`	`}`
`510`		`- result.emplace_back(std::move(info));`
	`510`	`+ result.emplace_back(info);`
`511`	`511`	`};`
`512`	`512`	`return result;`
`513`	`513`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,7 @@ namespace edm {`
`75`	`75`
`76`	`76`	`std::vector<eventsetup::ESModuleProducesInfo> EventSetupTestHelper::producesInfo() const {`
`77`	`77`	`std::vector<eventsetup::ESModuleProducesInfo> producesInfo;`
	`78`	`+ producesInfo.reserve(resolvers_.size());`
`78`	`79`	`for (auto const& p : resolvers_) {`
`79`	`80`	`producesInfo.emplace_back(p.recordKey_, p.dataKey_, p.resolver_->produceMethodID());`
`80`	`81`	`}`