[Misc2][clang-tidy] make deleted function public

Author: smuzaffar

CalibCalorimetry/EcalTrivialCondModules/interface/ESTrivialConditionRetriever.h

@@ -40,6 +40,8 @@ namespace edm {
 class ESTrivialConditionRetriever : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder {
 public:
   ESTrivialConditionRetriever(const edm::ParameterSet& pset);
+  ESTrivialConditionRetriever(const ESTrivialConditionRetriever&) = delete;                   // stop default
+  const ESTrivialConditionRetriever& operator=(const ESTrivialConditionRetriever&) = delete;  // stop default
   ~ESTrivialConditionRetriever() override;
 
   // ---------- member functions ---------------------------
@@ -64,9 +66,6 @@ class ESTrivialConditionRetriever : public edm::ESProducer, public edm::EventSet
                       edm::ValidityInterval&) override;
 
 private:
-  ESTrivialConditionRetriever(const ESTrivialConditionRetriever&) = delete;                   // stop default
-  const ESTrivialConditionRetriever& operator=(const ESTrivialConditionRetriever&) = delete;  // stop default
-
   void getWeightsFromConfiguration(const edm::ParameterSet& ps);
 
   // data members

CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h

@@ -123,6 +123,8 @@ namespace edm {
 class EcalTrivialConditionRetriever : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder {
 public:
   EcalTrivialConditionRetriever(const edm::ParameterSet& pset);
+  EcalTrivialConditionRetriever(const EcalTrivialConditionRetriever&) = delete;                   // stop default
+  const EcalTrivialConditionRetriever& operator=(const EcalTrivialConditionRetriever&) = delete;  // stop default
   ~EcalTrivialConditionRetriever() override;
 
   // ---------- member functions ---------------------------
@@ -202,9 +204,6 @@ class EcalTrivialConditionRetriever : public edm::ESProducer, public edm::EventS
                       edm::ValidityInterval&) override;
 
 private:
-  EcalTrivialConditionRetriever(const EcalTrivialConditionRetriever&) = delete;                   // stop default
-  const EcalTrivialConditionRetriever& operator=(const EcalTrivialConditionRetriever&) = delete;  // stop default
-
   void getWeightsFromConfiguration(const edm::ParameterSet& ps);
 
   // data members

CalibCalorimetry/HcalTPGAlgos/interface/XMLProcessor.h

@@ -137,6 +137,8 @@ class XMLProcessor {
     return instance;
   }
 
+  XMLProcessor(const XMLProcessor&) = delete;  // stop default
+
   // returns XML std::string if target == "string" otherwise NULL
   XMLCh* serializeDOM(XERCES_CPP_NAMESPACE::DOMNode* node, std::string target = "stdout");
 
@@ -161,8 +163,6 @@ class XMLProcessor {
 private:
   XMLProcessor();
 
-  XMLProcessor(const XMLProcessor&) = delete;  // stop default
-
   //const XMLProcessor& operator=(const XMLProcessor&); // stop default
 
   // ---------- member data --------------------------------

CalibTracker/SiStripESProducers/interface/Phase2TrackerCablingESProducer.h

@@ -11,14 +11,13 @@ class Phase2TrackerCablingRcd;
 class Phase2TrackerCablingESProducer : public edm::ESProducer {
 public:
   Phase2TrackerCablingESProducer(const edm::ParameterSet&);
+  Phase2TrackerCablingESProducer(const Phase2TrackerCablingESProducer&) = delete;
+  const Phase2TrackerCablingESProducer& operator=(const Phase2TrackerCablingESProducer&) = delete;
   ~Phase2TrackerCablingESProducer() override;
 
   virtual std::unique_ptr<Phase2TrackerCabling> produce(const Phase2TrackerCablingRcd&);
 
 private:
-  Phase2TrackerCablingESProducer(const Phase2TrackerCablingESProducer&) = delete;
-  const Phase2TrackerCablingESProducer& operator=(const Phase2TrackerCablingESProducer&) = delete;
-
   virtual Phase2TrackerCabling* make(const Phase2TrackerCablingRcd&) = 0;
 };
 

CalibTracker/SiStripESProducers/interface/SiStripGainESSource.h

@@ -17,6 +17,8 @@ class SiStripApvGainRcd;
 class SiStripGainESSource : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder {
 public:
   SiStripGainESSource(const edm::ParameterSet&);
+  SiStripGainESSource(const SiStripGainESSource&) = delete;
+  const SiStripGainESSource& operator=(const SiStripGainESSource&) = delete;
   ~SiStripGainESSource() override { ; }
 
   virtual std::unique_ptr<SiStripApvGain> produce(const SiStripApvGainRcd&);
@@ -27,9 +29,6 @@ class SiStripGainESSource : public edm::ESProducer, public edm::EventSetupRecord
                       edm::ValidityInterval&) override;
 
 private:
-  SiStripGainESSource(const SiStripGainESSource&) = delete;
-  const SiStripGainESSource& operator=(const SiStripGainESSource&) = delete;
-
   virtual SiStripApvGain* makeGain() = 0;
 };
 

CalibTracker/SiStripESProducers/interface/SiStripNoiseESSource.h

@@ -17,6 +17,8 @@ class SiStripNoisesRcd;
 class SiStripNoiseESSource : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder {
 public:
   SiStripNoiseESSource(const edm::ParameterSet&);
+  SiStripNoiseESSource(const SiStripNoiseESSource&) = delete;
+  const SiStripNoiseESSource& operator=(const SiStripNoiseESSource&) = delete;
   ~SiStripNoiseESSource() override { ; }
 
   virtual std::unique_ptr<SiStripNoises> produce(const SiStripNoisesRcd&);
@@ -27,9 +29,6 @@ class SiStripNoiseESSource : public edm::ESProducer, public edm::EventSetupRecor
                       edm::ValidityInterval&) override;
 
 private:
-  SiStripNoiseESSource(const SiStripNoiseESSource&) = delete;
-  const SiStripNoiseESSource& operator=(const SiStripNoiseESSource&) = delete;
-
   virtual SiStripNoises* makeNoise() = 0;
 };
 

CalibTracker/SiStripESProducers/interface/SiStripPedestalsESSource.h

@@ -17,6 +17,8 @@ class SiStripPedestalsRcd;
 class SiStripPedestalsESSource : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder {
 public:
   SiStripPedestalsESSource(const edm::ParameterSet&);
+  SiStripPedestalsESSource(const SiStripPedestalsESSource&) = delete;
+  const SiStripPedestalsESSource& operator=(const SiStripPedestalsESSource&) = delete;
   ~SiStripPedestalsESSource() override { ; }
 
   virtual std::unique_ptr<SiStripPedestals> produce(const SiStripPedestalsRcd&);
@@ -27,9 +29,6 @@ class SiStripPedestalsESSource : public edm::ESProducer, public edm::EventSetupR
                       edm::ValidityInterval&) override;
 
 private:
-  SiStripPedestalsESSource(const SiStripPedestalsESSource&) = delete;
-  const SiStripPedestalsESSource& operator=(const SiStripPedestalsESSource&) = delete;
-
   virtual SiStripPedestals* makePedestals() = 0;
 };
 

CalibTracker/SiStripESProducers/plugins/fake/SiStripTemplateEmptyFakeESSource.h

@@ -20,6 +20,8 @@ template <typename TObject, typename TRecord>
 class SiStripTemplateEmptyFakeESSource : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder {
 public:
   SiStripTemplateEmptyFakeESSource(const edm::ParameterSet&);
+  SiStripTemplateEmptyFakeESSource(const SiStripTemplateEmptyFakeESSource&) = delete;
+  const SiStripTemplateEmptyFakeESSource& operator=(const SiStripTemplateEmptyFakeESSource&) = delete;
   ~SiStripTemplateEmptyFakeESSource() override{};
 
   std::unique_ptr<TObject> produce(const TRecord&);
@@ -28,9 +30,6 @@ class SiStripTemplateEmptyFakeESSource : public edm::ESProducer, public edm::Eve
   void setIntervalFor(const edm::eventsetup::EventSetupRecordKey&,
                       const edm::IOVSyncValue& iov,
                       edm::ValidityInterval& iValidity) override;
-
-  SiStripTemplateEmptyFakeESSource(const SiStripTemplateEmptyFakeESSource&) = delete;
-  const SiStripTemplateEmptyFakeESSource& operator=(const SiStripTemplateEmptyFakeESSource&) = delete;
 };
 
 template <typename TObject, typename TRecord>

CaloOnlineTools/HcalOnlineDb/interface/XMLLUTLoader.h

@@ -50,6 +50,8 @@ class XMLLUTLoader : public XMLDOMBlock {
   XMLLUTLoader();
   XMLLUTLoader(XMLProcessor::loaderBaseConfig* config,
                std::string templateBase = "HCAL_TRIG_PRIM_LOOKUP_TABLE.XMLloader.template");
+  XMLLUTLoader(const XMLLUTLoader&) = delete;  // stop default
+  const XMLLUTLoader& operator=(const XMLLUTLoader&) = delete;  // stop default
   ~XMLLUTLoader() override;
 
   int addLUT(lutDBConfig* config, std::string templateFileName = "HCAL_TRIG_PRIM_LOOKUP_TABLE.dataset.template");
@@ -58,11 +60,6 @@ class XMLLUTLoader : public XMLDOMBlock {
                    std::string templateFileName = "HCAL_TRIG_PRIM_LOOKUP_TABLE.checksums.template");
 
   int createLoader(const std::vector<int>& crate_number, const std::vector<std::string>& file_name);
-
-private:
-  XMLLUTLoader(const XMLLUTLoader&) = delete;  // stop default
-
-  const XMLLUTLoader& operator=(const XMLLUTLoader&) = delete;  // stop default
 };
 
 #endif

DQM/SiStripCommissioningSources/interface/SiStripCommissioningSource.h

@@ -41,16 +41,17 @@ class SiStripCommissioningSource : public edm::EDAnalyzer {
   typedef dqm::legacy::MonitorElement MonitorElement;
 
   SiStripCommissioningSource(const edm::ParameterSet&);
+
+  /** Private default constructor. */
+  SiStripCommissioningSource() = delete;
+
   ~SiStripCommissioningSource() override;
 
   void beginRun(edm::Run const&, const edm::EventSetup&) override;
   void analyze(const edm::Event&, const edm::EventSetup&) override;
   void endJob() override;
 
 private:  // ---------- Private methods ----------
-  /** Private default constructor. */
-  SiStripCommissioningSource() = delete;
-
   /** */
   DQMStore* const dqm(std::string method = "") const;