Skip to content

Commit 3abb3d5

Browse files
committed
[ALCA-DB] Fix dead assignments
1 parent 8f2b354 commit 3abb3d5

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

CalibTracker/SiStripCommon/plugins/ShallowGainCalibration.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ bool ShallowGainCalibration::isFarFromBorder(TrajectoryStateOnSurface* trajState
249249
const RectangularPlaneBounds* rectangularBounds(dynamic_cast<const RectangularPlaneBounds*>(&(plane.bounds())));
250250

251251
double DistFromBorder = 1.0;
252-
double HalfLength = it->surface().bounds().length() / 2.0;
252+
double HalfLength;
253253

254254
if (trapezoidalBounds) {
255255
std::array<const float, 4> const& parameters = (*trapezoidalBounds).parameters();

Calibration/TkAlCaRecoProducers/src/AlcaBeamSpotManager.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ void AlcaBeamSpotManager::readLumi(const LuminosityBlock &iLumi) {
4747
if (beamSpotHandle.isValid()) { // check the product
4848
std::pair<edm::Timestamp, reco::BeamSpot> time_bs(iLumi.beginTime(), *beamSpotHandle);
4949
beamSpotMap_[iLumi.luminosityBlock()] = time_bs;
50-
const BeamSpot *aBeamSpot = &beamSpotMap_[iLumi.luminosityBlock()].second;
51-
aBeamSpot = beamSpotHandle.product();
50+
const BeamSpot *aBeamSpot = beamSpotHandle.product();
5251
LogInfo("AlcaBeamSpotManager") << "Lumi: " << iLumi.luminosityBlock() << std::endl;
5352
LogInfo("AlcaBeamSpotManager") << *aBeamSpot << std::endl;
5453
} else {

CondCore/CondDB/src/ConnectionPool.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ namespace cond {
4949
setFrontierSecurity(connectionPset.getUntrackedParameter<std::string>("security", m_frontierSecurity));
5050
int messageLevel =
5151
connectionPset.getUntrackedParameter<int>("messageLevel", 0); //0 corresponds to Error level, current default
52-
coral::MsgLevel level = m_messageLevel;
52+
coral::MsgLevel level;
5353
switch (messageLevel) {
5454
case 0:
5555
level = coral::Error;

CondFormats/RPCObjects/src/RPCReadOutMapping.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ std::vector<const LinkBoardSpec *> RPCReadOutMapping::getLBforChamber(const std:
180180
linkboard.dccInputChannelNum = 1;
181181
linkboard.tbLinkInputNum = 1;
182182
linkboard.lbNumInLink = 0;
183-
const LinkBoardSpec *location = this->location(linkboard);
183+
const LinkBoardSpec *location = nullptr;
184184

185185
for (int k = 0; k < 18; k++) {
186186
linkboard.dccInputChannelNum = 1;

0 commit comments

Comments
 (0)