Skip to content

Commit 199a8c6

Browse files
committed
Fixed issue with plugin registration for CondHDF5ESSource
1 parent e2698df commit 199a8c6

File tree

10 files changed

+27
-28
lines changed

10 files changed

+27
-28
lines changed

CondCore/BTauPlugins/src/plugin.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
using namespace PhysicsTools::Calibration;
1717

1818
REGISTER_PLUGIN(CombinedTauTagRcd, CombinedTauTagCalibration);
19-
REGISTER_PLUGIN(BTauGenericMVAJetTagComputerRcd, MVAComputerContainer);
19+
REGISTER_PLUGIN_NO_SERIAL(BTauGenericMVAJetTagComputerRcd, MVAComputerContainer);
2020
REGISTER_PLUGIN_NO_SERIAL(TauTagMVAComputerRcd, MVAComputerContainer);
2121
REGISTER_PLUGIN(BTagTrackProbability2DRcd, TrackProbabilityCalibration);
2222
REGISTER_PLUGIN_NO_SERIAL(BTagTrackProbability3DRcd, TrackProbabilityCalibration);

CondCore/CTPPSPlugins/src/plugin.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ REGISTER_PLUGIN(CTPPSOpticsRcd, LHCOpticalFunctionsSetCollection);
4747
REGISTER_PLUGIN(PPSDirectSimulationDataRcd, PPSDirectSimulationData);
4848
REGISTER_PLUGIN(PPSPixelTopologyRcd, PPSPixelTopology);
4949
REGISTER_PLUGIN(PPSAlignmentConfigRcd, PPSAlignmentConfig);
50-
REGISTER_PLUGIN_NO_SERIAL(PPSAlignmentConfigurationRcd, PPSAlignmentConfiguration);
50+
REGISTER_PLUGIN(PPSAlignmentConfigurationRcd, PPSAlignmentConfiguration);
5151

5252
REGISTER_PLUGIN_INIT(PPSAssociationCutsRcd, PPSAssociationCuts, InitAssociationCuts);

CondCore/DQMPlugins/src/plugin.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ REGISTER_PLUGIN(DQMSummaryRcd, DQMSummary);
77
REGISTER_PLUGIN(HDQMSummaryRcd, HDQMSummary);
88
#include "CondFormats/Common/interface/FileBlob.h"
99
#include "CondFormats/DataRecord/interface/DQMReferenceHistogramRootFileRcd.h"
10-
REGISTER_PLUGIN(DQMReferenceHistogramRootFileRcd, FileBlob);
10+
REGISTER_PLUGIN_NO_SERIAL(DQMReferenceHistogramRootFileRcd, FileBlob);
1111
#include "CondFormats/DataRecord/interface/DQMXMLFileRcd.h"
1212
REGISTER_PLUGIN_NO_SERIAL(DQMXMLFileRcd, FileBlob);

CondCore/ESPlugins/src/plugin.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,14 @@
4646
#include "CondFormats/DataRecord/interface/ESChannelStatusRcd.h"
4747

4848
REGISTER_PLUGIN(ESGainRcd, ESGain);
49-
REGISTER_PLUGIN(ESPedestalsRcd, ESCondObjectContainer<ESPedestal>);
49+
REGISTER_PLUGIN(ESPedestalsRcd, ESPedestals); //is ESCondObjectContainer<ESPedestal> but needs to match name registered with EventSetup system
5050
REGISTER_PLUGIN(ESTimeSampleWeightsRcd, ESTimeSampleWeights);
51-
REGISTER_PLUGIN(ESIntercalibConstantsRcd, ESCondObjectContainer<float>);
51+
REGISTER_PLUGIN(ESIntercalibConstantsRcd, ESFloatCondObjectContainer); //is ESCondObjectContainer<float> but needs to match name registered with EventSetup system
5252
REGISTER_PLUGIN_NO_SERIAL(ESAngleCorrectionFactorsRcd, ESCondObjectContainer<float>);
5353
REGISTER_PLUGIN(ESADCToGeVConstantRcd, ESADCToGeVConstant);
5454
REGISTER_PLUGIN(ESMIPToGeVConstantRcd, ESMIPToGeVConstant);
5555
REGISTER_PLUGIN(ESThresholdsRcd, ESThresholds);
5656
REGISTER_PLUGIN(ESEEIntercalibConstantsRcd, ESEEIntercalibConstants);
5757
REGISTER_PLUGIN(ESMissingEnergyCalibrationRcd, ESMissingEnergyCalibration);
5858
REGISTER_PLUGIN(ESRecHitRatioCutsRcd, ESRecHitRatioCuts);
59-
REGISTER_PLUGIN(ESChannelStatusRcd, ESCondObjectContainer<ESChannelStatusCode>);
59+
REGISTER_PLUGIN(ESChannelStatusRcd, ESChannelStatus); //is ESCondObjectContainer<ESChannelStatusCode> but needs to match name registered with EventSetup system

CondCore/EcalPlugins/src/plugin.cc

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -178,12 +178,12 @@
178178
#include "CondFormats/EcalObjects/interface/EcalSCDynamicDPhiParameters.h"
179179
#include "CondFormats/DataRecord/interface/EcalSCDynamicDPhiParametersRcd.h"
180180

181-
REGISTER_PLUGIN(EcalPedestalsRcd, EcalCondObjectContainer<EcalPedestal>);
182-
REGISTER_PLUGIN(EcalWeightXtalGroupsRcd, EcalCondObjectContainer<EcalXtalGroupId>);
181+
REGISTER_PLUGIN(EcalPedestalsRcd, EcalPedestals); //is EcalCondObjectContainer<EcalPedestal>
182+
REGISTER_PLUGIN(EcalWeightXtalGroupsRcd, EcalWeightXtalGroups); // is EcalCondObjectContainer<EcalXtalGroupId>
183183
REGISTER_PLUGIN(EcalTBWeightsRcd, EcalTBWeights);
184-
REGISTER_PLUGIN(EcalGainRatiosRcd, EcalCondObjectContainer<EcalMGPAGainRatio>);
184+
REGISTER_PLUGIN(EcalGainRatiosRcd, EcalGainRatios); // is EcalCondObjectContainer<EcalMGPAGainRatio>
185185
REGISTER_PLUGIN(EcalLinearCorrectionsRcd, EcalTimeDependentCorrections);
186-
REGISTER_PLUGIN(EcalIntercalibConstantsRcd, EcalCondObjectContainer<float>);
186+
REGISTER_PLUGIN(EcalIntercalibConstantsRcd, EcalFloatCondObjectContainer); //is EcalCondObjectContainer<float>
187187
REGISTER_PLUGIN_NO_SERIAL(EcalIntercalibConstantsMCRcd, EcalCondObjectContainer<float>);
188188
REGISTER_PLUGIN_NO_SERIAL(EcalTimeCalibConstantsRcd, EcalCondObjectContainer<float>);
189189
REGISTER_PLUGIN_NO_SERIAL(EcalTimeCalibErrorsRcd, EcalCondObjectContainer<float>);
@@ -194,7 +194,7 @@ REGISTER_PLUGIN_NO_SERIAL(EcalLaserAlphasRcd, EcalCondObjectContainer<float>);
194194
REGISTER_PLUGIN(EcalLaserAPDPNRatiosRcd, EcalLaserAPDPNRatios);
195195
REGISTER_PLUGIN_NO_SERIAL(EcalLaserAPDPNRatiosMCRcd, EcalLaserAPDPNRatios);
196196
REGISTER_PLUGIN_NO_SERIAL(EcalLaserAPDPNRatiosRefRcd, EcalCondObjectContainer<float>);
197-
REGISTER_PLUGIN(EcalChannelStatusRcd, EcalCondObjectContainer<EcalChannelStatusCode>);
197+
REGISTER_PLUGIN(EcalChannelStatusRcd, EcalChannelStatus); //is EcalCondObjectContainer<EcalChannelStatusCode>
198198
REGISTER_PLUGIN_NO_SERIAL(EcalPFRecHitThresholdsRcd, EcalCondObjectContainer<float>);
199199
REGISTER_PLUGIN_NO_SERIAL(EcalPFSeedingThresholdsRcd, EcalCondObjectContainer<float>);
200200
REGISTER_PLUGIN(EcalClusterCrackCorrParametersRcd, EcalFunParams);
@@ -206,14 +206,14 @@ REGISTER_PLUGIN_NO_SERIAL(EcalClusterEnergyCorrectionObjectSpecificParametersRcd
206206
REGISTER_PLUGIN(EcalSimPulseShapeRcd, EcalSimPulseShape);
207207
REGISTER_PLUGIN(EcalSimComponentShapeRcd, EcalSimComponentShape);
208208

209-
REGISTER_PLUGIN(EcalMappingElectronicsRcd, EcalCondObjectContainer<EcalMappingElement>);
209+
REGISTER_PLUGIN(EcalMappingElectronicsRcd, EcalMappingElectronics); //is EcalCondObjectContainer<EcalMappingElement>
210210

211-
REGISTER_PLUGIN(EcalTPGPedestalsRcd, EcalCondObjectContainer<EcalTPGPedestal>);
211+
REGISTER_PLUGIN(EcalTPGPedestalsRcd, EcalTPGPedestals); //is EcalCondObjectContainer<EcalTPGPedestal>
212212
REGISTER_PLUGIN(EcalTPGFineGrainEBGroupRcd, EcalTPGFineGrainEBGroup);
213213
REGISTER_PLUGIN(EcalTPGFineGrainEBIdMapRcd, EcalTPGFineGrainEBIdMap);
214214
REGISTER_PLUGIN(EcalTPGFineGrainStripEERcd, EcalTPGFineGrainStripEE);
215215
REGISTER_PLUGIN(EcalTPGFineGrainTowerEERcd, EcalTPGFineGrainTowerEE);
216-
REGISTER_PLUGIN(EcalTPGLinearizationConstRcd, EcalCondObjectContainer<EcalTPGLinearizationConstant>);
216+
REGISTER_PLUGIN(EcalTPGLinearizationConstRcd, EcalTPGLinearizationConst);// is EcalCondObjectContainer<EcalTPGLinearizationConstant>
217217
REGISTER_PLUGIN(EcalTPGLutGroupRcd, EcalTPGLutGroup);
218218
REGISTER_PLUGIN(EcalTPGLutIdMapRcd, EcalTPGLutIdMap);
219219
REGISTER_PLUGIN(EcalTPGPhysicsConstRcd, EcalTPGPhysicsConst);
@@ -225,26 +225,26 @@ REGISTER_PLUGIN(EcalTPGOddWeightIdMapRcd, EcalTPGOddWeightIdMap);
225225

226226
REGISTER_PLUGIN(EcalTPGTPModeRcd, EcalTPGTPMode);
227227

228-
REGISTER_PLUGIN(EcalTPGCrystalStatusRcd, EcalCondObjectContainer<EcalTPGCrystalStatusCode>);
228+
REGISTER_PLUGIN(EcalTPGCrystalStatusRcd, EcalTPGCrystalStatus); // is EcalCondObjectContainer<EcalTPGCrystalStatusCode>
229229
REGISTER_PLUGIN(EcalTPGTowerStatusRcd, EcalTPGTowerStatus);
230230
REGISTER_PLUGIN(EcalTPGStripStatusRcd, EcalTPGStripStatus);
231231
REGISTER_PLUGIN(EcalTPGSpikeRcd, EcalTPGSpike);
232232

233-
REGISTER_PLUGIN(EcalDCSTowerStatusRcd, EcalCondTowerObjectContainer<EcalChannelStatusCode>);
234-
REGISTER_PLUGIN(EcalDAQTowerStatusRcd, EcalCondTowerObjectContainer<EcalDAQStatusCode>);
233+
REGISTER_PLUGIN(EcalDCSTowerStatusRcd,EcalDCSTowerStatus); // is EcalCondTowerObjectContainer<EcalChannelStatusCode>
234+
REGISTER_PLUGIN(EcalDAQTowerStatusRcd, EcalDAQTowerStatus); // is EcalCondTowerObjectContainer<EcalDAQStatusCode>
235235

236-
REGISTER_PLUGIN(EcalDQMChannelStatusRcd, EcalCondObjectContainer<EcalDQMStatusCode>);
237-
REGISTER_PLUGIN(EcalDQMTowerStatusRcd, EcalCondTowerObjectContainer<EcalDQMStatusCode>);
236+
REGISTER_PLUGIN(EcalDQMChannelStatusRcd, EcalDQMChannelStatus); // is EcalCondObjectContainer<EcalDQMStatusCode>
237+
REGISTER_PLUGIN(EcalDQMTowerStatusRcd, EcalDQMTowerStatus); // is EcalCondTowerObjectContainer<EcalDQMStatusCode>
238238

239239
REGISTER_PLUGIN(EcalSRSettingsRcd, EcalSRSettings);
240240
REGISTER_PLUGIN(EcalSampleMaskRcd, EcalSampleMask);
241241

242242
REGISTER_PLUGIN(EcalTimeBiasCorrectionsRcd, EcalTimeBiasCorrections);
243243

244244
REGISTER_PLUGIN(EcalSamplesCorrelationRcd, EcalSamplesCorrelation);
245-
REGISTER_PLUGIN(EcalPulseShapesRcd, EcalCondObjectContainer<EcalPulseShape>);
246-
REGISTER_PLUGIN(EcalPulseCovariancesRcd, EcalCondObjectContainer<EcalPulseCovariance>);
247-
REGISTER_PLUGIN(EcalPulseSymmCovariancesRcd, EcalCondObjectContainer<EcalPulseSymmCovariance>);
245+
REGISTER_PLUGIN(EcalPulseShapesRcd, EcalPulseShapes); //is EcalCondObjectContainer<EcalPulseShape>
246+
REGISTER_PLUGIN(EcalPulseCovariancesRcd, EcalPulseCovariances); //is EcalCondObjectContainer<EcalPulseCovariance>
247+
REGISTER_PLUGIN(EcalPulseSymmCovariancesRcd, EcalPulseSymmCovariances); //is EcalCondObjectContainer<EcalPulseSymmCovariance>
248248

249249
REGISTER_PLUGIN(EcalMustacheSCParametersRcd, EcalMustacheSCParameters);
250250
REGISTER_PLUGIN(EcalSCDynamicDPhiParametersRcd, EcalSCDynamicDPhiParameters);

CondCore/HcalPlugins/src/plugin.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,4 +106,4 @@ REGISTER_PLUGIN(HcalSiPMParametersRcd, HcalSiPMParameters);
106106
REGISTER_PLUGIN_INIT(HcalSiPMCharacteristicsRcd, HcalSiPMCharacteristics, InitHcalSiPMCharacteristics);
107107
REGISTER_PLUGIN(HcalTPParametersRcd, HcalTPParameters);
108108
REGISTER_PLUGIN(HcalTPChannelParametersRcd, HcalTPChannelParameters);
109-
REGISTER_PLUGIN(HFPhase1PMTParamsRcd, HcalItemCollById<HFPhase1PMTData>);
109+
REGISTER_PLUGIN(HFPhase1PMTParamsRcd, HFPhase1PMTParams); // is HcalItemCollById<HFPhase1PMTData>

CondCore/L1TPlugins/src/RCTRecords.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,4 @@ REGISTER_PLUGIN(L1CaloEcalScaleRcd, L1CaloEcalScale);
2222
#include "CondFormats/L1TObjects/interface/L1CaloHcalScale.h"
2323
#include "CondFormats/DataRecord/interface/L1CaloHcalScaleRcd.h"
2424

25-
//L1CaloHcalScale is same as L1RCTParameters
26-
REGISTER_PLUGIN_NO_SERIAL(L1CaloHcalScaleRcd, L1CaloHcalScale);
25+
REGISTER_PLUGIN(L1CaloHcalScaleRcd, L1CaloHcalScale);

CondCore/SiPhase2TrackerPlugins/src/plugin.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@
99
REGISTER_PLUGIN(TrackerDetToDTCELinkCablingMapRcd, TrackerDetToDTCELinkCablingMap);
1010
REGISTER_PLUGIN(SiPhase2OuterTrackerLorentzAngleRcd, SiPhase2OuterTrackerLorentzAngle);
1111
REGISTER_PLUGIN_NO_SERIAL(SiPhase2OuterTrackerLorentzAngleSimRcd, SiPhase2OuterTrackerLorentzAngle);
12-
REGISTER_PLUGIN(SiPhase2OuterTrackerBadStripRcd, SiStripBadStrip);
12+
REGISTER_PLUGIN_NO_SERIAL(SiPhase2OuterTrackerBadStripRcd, SiStripBadStrip);

CondCore/SiPixelPlugins/plugins/plugin.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,4 +87,4 @@ REGISTER_PLUGIN(PixelCaenChannelIsOnRcd, PixelDCSObject<bool>);
8787
REGISTER_PLUGIN(PixelCaenChannelIMonRcd, PixelDCSObject<float>);
8888
REGISTER_PLUGIN(PixelCaenChannelRcd, PixelDCSObject<CaenChannel>);
8989

90-
REGISTER_PLUGIN(SiPixelDetVOffRcd, SiStripDetVOff);
90+
REGISTER_PLUGIN_NO_SERIAL(SiPixelDetVOffRcd, SiStripDetVOff);

CondFormats/MFObjects/plugins/plugin.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
#include "CondFormats/DataRecord/interface/MFGeometryFileRcd.h"
66

77
REGISTER_PLUGIN(MagFieldConfigRcd, MagFieldConfig);
8-
REGISTER_PLUGIN(MFGeometryFileRcd, FileBlob);
8+
REGISTER_PLUGIN_NO_SERIAL(MFGeometryFileRcd, FileBlob);

0 commit comments

Comments
 (0)