Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move discovery, scheme and informer to pkg/runtime #682

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Jun 21, 2024

What type of PR is this?

Move packages that are not business-specific, but are more common at runtime, to pkg/runtime.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@clusterpedia-bot
Copy link

Hi @Iceber,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@Iceber Iceber force-pushed the pkg_runtime branch 2 times, most recently from cab4f41 to 595f0f8 Compare June 21, 2024 10:20
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jun 24, 2024
@Iceber Iceber changed the title [WIP] move discovery, scheme and informer to pkg/runtime move discovery, scheme and informer to pkg/runtime Jun 24, 2024
@Iceber Iceber added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 24, 2024
@Iceber Iceber merged commit 426c66f into clusterpedia-io:main Jun 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants