Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove admission middleware from apiserver #673

Closed
Iceber opened this issue Jun 14, 2024 · 1 comment · Fixed by #674
Closed

Remove admission middleware from apiserver #673

Iceber opened this issue Jun 14, 2024 · 1 comment · Fixed by #674
Labels
kind/feature New feature

Comments

@Iceber
Copy link
Member

Iceber commented Jun 14, 2024

What would you like to be added?

Remove admission middleware from apiserver

clusterpedia/cmd/apiserver/app/options/options.go

Line 71 in c7d1b82

Admission: genericoptions.NewAdmissionOptions(),

Why is this needed?

Clusterpedia's resource requests don't have to perform the same admission logic as kube apiserver's
And the admission plugins introduce additional dependencies on resources, such as #668 (comment)
@Iceber Iceber added the kind/feature New feature label Jun 14, 2024
@clusterpedia-bot
Copy link

Hi @Iceber,
Thanks for opening an issue!
We will look into it as soon as possible.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@Iceber Iceber mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

apiserver: remove admission middleware Iceber/clusterpedia
2 participants
@clusterpedia-bot @Iceber