diff --git a/package-lock.json b/package-lock.json index 835affb8cf..17fb985a04 100644 --- a/package-lock.json +++ b/package-lock.json @@ -16,7 +16,7 @@ "@dnd-kit/sortable": "^7.0.2", "@dnd-kit/utilities": "^3.2.1", "@juggle/resize-observer": "^3.3.1", - "ace-builds": "^1.34.0", + "ace-builds": "1.36.0", "balanced-match": "^1.0.2", "clsx": "^1.1.0", "d3-shape": "^1.3.7", @@ -4737,9 +4737,9 @@ } }, "node_modules/ace-builds": { - "version": "1.34.0", - "resolved": "https://registry.npmjs.org/ace-builds/-/ace-builds-1.34.0.tgz", - "integrity": "sha512-ZQqoV76wl4guDE5zvEnxCDrvy9gzLAwu7eD4ikYj/Gdlb4+qRLbb+aOFVnweZZRsHh089V0WVaw2NMNuiiEdTw==" + "version": "1.36.0", + "resolved": "https://registry.npmjs.org/ace-builds/-/ace-builds-1.36.0.tgz", + "integrity": "sha512-7to4F86V5N13EY4M9LWaGo2Wmr9iWe5CrYpc28F+/OyYCf7yd+xBV5x9v/GB73EBGGoYd89m6JjeIUjkL6Yw+w==" }, "node_modules/acorn": { "version": "8.12.1", diff --git a/package.json b/package.json index d511171d45..83f9a30830 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,7 @@ "@dnd-kit/sortable": "^7.0.2", "@dnd-kit/utilities": "^3.2.1", "@juggle/resize-observer": "^3.3.1", - "ace-builds": "^1.34.0", + "ace-builds": "1.36.0", "balanced-match": "^1.0.2", "clsx": "^1.1.0", "d3-shape": "^1.3.7", diff --git a/pages/app-layout/multi-layout-with-hidden-instances-iframe.page.tsx b/pages/app-layout/multi-layout-with-hidden-instances-iframe.page.tsx index 3e848ec557..3eed10f528 100644 --- a/pages/app-layout/multi-layout-with-hidden-instances-iframe.page.tsx +++ b/pages/app-layout/multi-layout-with-hidden-instances-iframe.page.tsx @@ -3,6 +3,7 @@ import React, { useRef, useState } from 'react'; import AppLayout from '~components/app-layout'; +import BreadcrumbGroup from '~components/breadcrumb-group'; import Header from '~components/header'; import ScreenreaderOnly from '~components/internal/components/screenreader-only'; import Link from '~components/link'; @@ -12,7 +13,7 @@ import SpaceBetween from '~components/space-between'; import './utils/external-widget'; import { IframeWrapper } from '../utils/iframe-wrapper'; import ScreenshotArea from '../utils/screenshot-area'; -import { Breadcrumbs, Tools } from './utils/content-blocks'; +import { Tools } from './utils/content-blocks'; import labels from './utils/labels'; function createView(name: string) { @@ -21,7 +22,17 @@ function createView(name: string) { } + breadcrumbs={ + name !== 'page2' && ( + event.preventDefault()} + items={[ + { text: 'Home', href: '#' }, + { text: name, href: `#${name}` }, + ]} + /> + ) + } navigationHide={true} content={ diff --git a/pages/dnd/commons.tsx b/pages/dnd/commons.tsx index cb2b49452a..2630ff6f21 100644 --- a/pages/dnd/commons.tsx +++ b/pages/dnd/commons.tsx @@ -4,12 +4,12 @@ import React from 'react'; import { Box, Button, SpaceBetween, StatusIndicator } from '~components'; -import { DndContainerProps } from '~components/internal/components/dnd-container/interfaces'; +import { DndAreaProps } from '~components/internal/components/dnd-area/interfaces'; import { Instance } from '../table/generate-data'; import { stateToStatusIndicator } from '../table/shared-configs'; -export const i18nStrings: DndContainerProps['i18nStrings'] = { +export const i18nStrings: DndAreaProps['i18nStrings'] = { dragHandleAriaLabel: 'Drag handle', dragHandleAriaDescription: "Use Space or Enter to activate drag for an item, then use the arrow keys to move the item's position. To complete the position move, use Space or Enter, or to discard the move, use Escape.", diff --git a/pages/dnd/reorderable-containers.tsx b/pages/dnd/reorderable-containers.tsx index 5d127cf86f..a3b0bbf2d8 100644 --- a/pages/dnd/reorderable-containers.tsx +++ b/pages/dnd/reorderable-containers.tsx @@ -1,11 +1,11 @@ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 -import React, { ForwardedRef, forwardRef } from 'react'; +import React, { ForwardedRef } from 'react'; import clsx from 'clsx'; import { Box, Container, SpaceBetween } from '~components'; -import { DndContainer } from '~components/internal/components/dnd-container'; +import { DndArea } from '~components/internal/components/dnd-area'; import DragHandle, { DragHandleProps } from '~components/internal/components/drag-handle'; import { ArrowButtons, i18nStrings } from './commons'; @@ -15,8 +15,7 @@ import styles from './styles.scss'; interface OptionProps