Skip to content

Commit 4a35437

Browse files
fix: Key-value pair border not center-aligned (#3031)
1 parent f1ff83f commit 4a35437

File tree

2 files changed

+65
-2
lines changed

2 files changed

+65
-2
lines changed
+42
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
// SPDX-License-Identifier: Apache-2.0
3+
import * as React from 'react';
4+
5+
import ColumnLayout from '~components/column-layout';
6+
7+
import ScreenshotArea from '../utils/screenshot-area';
8+
9+
export default function ColumnLayoutPage() {
10+
return (
11+
<>
12+
<h1>Border alignment test</h1>
13+
<p>
14+
The vertical border line drawn between items should be in the center of the component, i.e. it must line up with
15+
where the two coloured bars meet below.
16+
</p>
17+
<ScreenshotArea>
18+
<ColumnLayout variant="text-grid" columns={2} minColumnWidth={150}>
19+
<div>
20+
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et
21+
dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex
22+
ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat
23+
nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit
24+
anim id est laborum.
25+
</div>
26+
<div>
27+
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et
28+
dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex
29+
ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat
30+
nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit
31+
anim id est laborum.
32+
</div>
33+
</ColumnLayout>
34+
35+
<div style={{ display: 'flex', marginTop: 10 }}>
36+
<div style={{ width: '50%', background: 'blue', height: '10px' }}></div>
37+
<div style={{ width: '50%', background: 'orange', height: '10px' }}></div>
38+
</div>
39+
</ScreenshotArea>
40+
</>
41+
);
42+
}

src/column-layout/flexible-column-layout/styles.scss

+23-2
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,33 @@ dl.css-grid {
1919

2020
&.grid-variant-text-grid {
2121
> .item {
22-
border-inline-start: awsui.$border-divider-section-width solid awsui.$color-border-divider-default;
2322
padding-inline: awsui.$space-grid-gutter;
23+
position: relative;
24+
25+
&::before {
26+
content: '';
27+
position: absolute;
28+
inset-block-start: 0;
29+
inset-block-end: 0;
30+
inset-inline-start: 0;
31+
32+
border-inline-start: awsui.$border-divider-section-width solid awsui.$color-border-divider-default;
33+
34+
transform: translateX(calc(-0.5 * awsui.$space-grid-gutter));
35+
}
36+
37+
@include styles.with-direction('rtl') {
38+
&::before {
39+
transform: translateX(calc(0.5 * awsui.$space-grid-gutter));
40+
}
41+
}
2442

2543
&.first-column {
26-
border-inline-start: 0;
2744
padding-inline-start: 0;
45+
46+
&::before {
47+
display: none;
48+
}
2849
}
2950
}
3051
}

0 commit comments

Comments
 (0)