From 396d8fff79e17cc9e511a186b3830fe0116b54f7 Mon Sep 17 00:00:00 2001 From: RB <7775707+nitrocode@users.noreply.github.com> Date: Fri, 22 Nov 2024 04:44:43 -0600 Subject: [PATCH 1/3] fix: add missing security group outputs --- outputs.tf | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/outputs.tf b/outputs.tf index 72a8d47..adf4b38 100644 --- a/outputs.tf +++ b/outputs.tf @@ -13,6 +13,16 @@ output "vpn_endpoint_dns_name" { description = "The DNS Name of the Client VPN Endpoint Connection." } +output "vpn_security_group" { + value = local.enabled ? module.vpn_security_group : null + description = "The security group module of the Client VPN Endpoint Connection." +} + +output "vpn_security_group_id" { + value = local.enabled ? module.vpn_security_group.id : null + description = "The security group ID of the Client VPN Endpoint Connection." +} + output "client_configuration" { value = local.enabled ? join("", data.awsutils_ec2_client_vpn_export_client_config.default[*].client_configuration) : null description = "VPN Client Configuration data." From 1666347ce432a4d23ffe2ad4f8d3578f9cf294c1 Mon Sep 17 00:00:00 2001 From: RB <7775707+nitrocode@users.noreply.github.com> Date: Fri, 22 Nov 2024 06:00:51 -0600 Subject: [PATCH 2/3] fix: tflint issues in examples --- examples/complete/outputs.tf | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/examples/complete/outputs.tf b/examples/complete/outputs.tf index f0dc7de..e794248 100644 --- a/examples/complete/outputs.tf +++ b/examples/complete/outputs.tf @@ -1,16 +1,20 @@ output "vpn_endpoint_arn" { - value = module.ec2_client_vpn.vpn_endpoint_arn + value = module.ec2_client_vpn.vpn_endpoint_arn + description = "The ARN of the Client VPN Endpoint Connection." } output "vpn_endpoint_id" { - value = module.ec2_client_vpn.vpn_endpoint_id + value = module.ec2_client_vpn.vpn_endpoint_id + description = "The ID of the Client VPN Endpoint Connection." } output "vpn_endpoint_dns_name" { - value = module.ec2_client_vpn.vpn_endpoint_dns_name + value = module.ec2_client_vpn.vpn_endpoint_dns_name + description = "The DNS Name of the Client VPN Endpoint Connection." } output "client_configuration" { - sensitive = true - value = module.ec2_client_vpn.full_client_configuration + sensitive = true + value = module.ec2_client_vpn.full_client_configuration + description = "VPN Client Configuration data." } From 00763859b038fa4cae96be57579793d5ee3f4a2c Mon Sep 17 00:00:00 2001 From: RB <7775707+nitrocode@users.noreply.github.com> Date: Fri, 13 Dec 2024 01:19:49 -0600 Subject: [PATCH 3/3] Apply suggestions from code review --- outputs.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/outputs.tf b/outputs.tf index adf4b38..00046d5 100644 --- a/outputs.tf +++ b/outputs.tf @@ -14,12 +14,12 @@ output "vpn_endpoint_dns_name" { } output "vpn_security_group" { - value = local.enabled ? module.vpn_security_group : null + value = local.security_group_enabled ? module.vpn_security_group : null description = "The security group module of the Client VPN Endpoint Connection." } output "vpn_security_group_id" { - value = local.enabled ? module.vpn_security_group.id : null + value = local.security_group_enabled ? module.vpn_security_group.id : null description = "The security group ID of the Client VPN Endpoint Connection." }