Appending routes cause recreation of routes and rules

[nitrocode]

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Describe the Feature

Appending routes cause recreation of routes leading to failed terraform applies due to many unnecessary routing changes.

If we use a map for both var.authorization_rules and var.additional_routes, then we can use a for_each instead of count for auth rules and vpn routes and make the key something like {stage}-{cidr} or similar

terraform-aws-ec2-client-vpn/main.tf

Line 223 in 0e4f0d9

count = local.enabled ? length(var.authorization_rules) : 0

terraform-aws-ec2-client-vpn/main.tf

Line 233 in 0e4f0d9

count = local.enabled ? length(var.additional_routes) : 0

then we would be able to append routes and rules, avoid unnecessary deletions, and reduce the likelihood of the following error.

│ Error: error deleting client VPN route "cvpn-endpoint-snip,subnet-snip,10.66.0.0/15": timeout while waiting for resource to be gone (last state: 'deleting', timeout: 1m0s)

│ Error: error creating client VPN route "cvpn-endpoint-snip,subnet-snip,10.68.0.0/15": ConcurrentMutationLimitExceeded: Cannot initiate another change for this endpoint at this time. Please try again later.