Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing security group outputs #116

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: add missing security group outputs #116

wants to merge 4 commits into from

Conversation

nitrocode
Copy link
Member

what

  • add missing security group outputs

why

  • useful when we need to reference the security group that the vpn uses

references

@mergify mergify bot added the triage Needs triage label Nov 22, 2024
@nitrocode nitrocode added the patch A minor, backward compatible change label Nov 22, 2024
@richardgavel-ordinaryexperts
Copy link

Shouldn't the new outputs be based on local.security_group_enabled, not local.enabled?

nitrocode
nitrocode commented Dec 13, 2024
View reviewed changes
outputs.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode commented Dec 13, 2024
View reviewed changes
outputs.tf Outdated Show resolved Hide resolved
@nitrocode
Copy link
Member Author

/terratest

@nitrocode nitrocode marked this pull request as ready for review December 13, 2024 07:21
@nitrocode nitrocode requested review from a team as code owners December 13, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
patch A minor, backward compatible change triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output for security group created
2 participants
@nitrocode @richardgavel-ordinaryexperts