-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance enhancement opportunities #148
Comments
The bits about idle thread make me wonder if you just had too many processes running on your machine to conduct the audit well. There are definitely places to improve (one of the biggest would be to simply pull the CSS in pwastats domain instead of grabbing it from our netlify pattern library), but I don't think it is quite as bad are your screenshot indicates. |
Thanks for pointing this out @grigs! |
|
You could include @cloudfour/cloudfour.com-patterns as a submodule and build a stylesheet only importing the parts that are necessary? (Just brainstorming.) Alternatively we could use the cloudfour.com stylesheet path to at least use the same cached resource for visitors of both sites? (@grigs mentioned that it's using the pattern library path, which has far less traffic) |
This is probably a separate issue, but we've talked about figuring out some automated way of grabbing a PWA's touch icon... currently it's manual process of spelunking through |
@tylersticka Update on CSS:
|
I honestly am not sure why/how this would be the case? 🤔
@grigs likes digging through analytics, not sure if it's possible to determine this.
I'm open to this, I'd just need to see how much complexity or fragility it adds. |
It seems like the cloudfour.com css file has a lot more prefixes in it and pixel fallbacks for rems (maybe it has different autoprefixer options?) Here is the diff: https://www.diffchecker.com/VqDVDgKb (cloudfour.com on the left, pattern library on the right) If we went with the nodejs pipeline approach, we would probably nest the jekyll process in the nodejs process (so you would run |
Running the Chrome DevTools Performance Audit, there are some opportunities for us to make this better.
The text was updated successfully, but these errors were encountered: