Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user.tap() method #75

Open
calebeby opened this issue May 26, 2021 · 1 comment
Open

Add user.tap() method #75

calebeby opened this issue May 26, 2021 · 1 comment
Labels

Comments

@calebeby
Copy link
Member

Puppeteer has a .tap() method, which fires slightly different events from .click. We could add this method to our user API.

TODO: figure out the benefits of having this method (specifically which events does it fire differently, and when does it matter), and decide if it makes sense to add this.

It is also worth considering whether adding an option to .click, like user.click(el, { type: 'tap' }) is better

@calebeby
Copy link
Member Author

calebeby commented Sep 3, 2021

I think I'm gonna put this off until we have test code on a real project that needs .tap where the behavior of .click is different enough to actually matter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant