Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out @pleasantest/testing-library and @pleasantest/jest-dom and @pleasantest/user-event #57

Open
calebeby opened this issue Apr 30, 2021 · 2 comments
Assignees

Comments

@calebeby
Copy link
Member

Those could be three separate libraries (still maintained in this repo, but published to npm separately) so that they could be used on projects that don't use test mule but do use puppeteer/jest (like a client project).

The main roadblocks:

  • They are in the same build scripts
  • This repo is not set up as a monorepo: look into lerna and bolt
  • They all depend on the vite server to send the client-side library files. We do need some kind of server to send the files so that the browser can cache the libraries, but really there is no benefit of using vite for this over a boring http server based on the http module. It would probably be just a few lines of code (and reasonably fast) to spin up and spin down the http server per function call
@calebeby calebeby self-assigned this Apr 30, 2021
@calebeby
Copy link
Member Author

calebeby commented May 7, 2021

I thought of one thing that might complicate this: those methods throw errors that have the messageForBrowser property, which Jest trips on. (the withBrowser wrapper fixes it so Jest doesn't trip on it). I think I saw that jest-circus fixes it (?) (relevant issue: #12)

@calebeby calebeby changed the title Separate out @test-mule/testing-library and @test-mule/jest-dom and @test-mule/user-event Separate out @pleasantest/testing-library and @pleasantest/jest-dom and @pleasantest/user-event May 26, 2021
@calebeby
Copy link
Member Author

This is a little bit easier now that #115 separates the HTTP server for jest-dom, user-event, and testing-library from the HTTP server for runJS, loadJS, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant