Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix override problem #234

Open
spaceninja opened this issue Feb 23, 2021 · 2 comments
Open

Fix override problem #234

spaceninja opened this issue Feb 23, 2021 · 2 comments
Assignees

Comments

@spaceninja
Copy link
Member

spaceninja commented Feb 23, 2021

In both cloudfour.com-patterns and a client project, the following section is in the .eslintrc.js file to keep linting working. We should probably find a fix here instead:

module.exports = {
  overrides: [
    {
      // This override shouldn't be necessary because the cloudfour plugin has the exact same override,
      // but eslint isn't merging the overrides from the cloudfour plugin and the mdx plugin as expected.
      // Specifying this here fixes it.
      files: ['*.ts', '*.tsx'],
      parser: require.resolve(
        // eslint-disable-next-line @cloudfour/node/no-extraneous-require
        '@typescript-eslint/parser'
      ),
      parserOptions: {
        project: './tsconfig.json',
      },
    },
  ],
};
@spaceninja
Copy link
Member Author

ATTN @calebeby

@calebeby calebeby self-assigned this Feb 24, 2021
@spaceninja
Copy link
Member Author

Reassigning to myself to update the cloud four patterns repo and see if this is still an issue after the change to a flat config file.

@spaceninja spaceninja assigned spaceninja and unassigned calebeby Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants