Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting OpenTelemetry #9

Open
ibotty opened this issue Feb 1, 2024 · 11 comments
Open

Consider supporting OpenTelemetry #9

ibotty opened this issue Feb 1, 2024 · 11 comments

Comments

@ibotty
Copy link

ibotty commented Feb 1, 2024

We are already running OpenTelemetry so it would be great to allow easy intergration into apps using foundations.

@inikulin
Copy link
Collaborator

inikulin commented Feb 1, 2024

Could you elaborate a bit more about what kind of integration you expect?

@Noah-Kennedy
Copy link
Collaborator

@ibotty which apis are you interested in here?

Generic OTEL support for tracing and logging is likely to be fairly simple, metrics would be more complicated though.

@ibotty
Copy link
Author

ibotty commented Feb 3, 2024

Sorry for not answering earlier. I was busy.

For some rust projects we are using tracing, tracing-opentelemetry and opentelemetry-otlp to export traces. We don't yet use metrics via OpenTelemetry.

ATM setting that up is quiet a handful of boilerplate in Rust. It seems to be kind-of in scope for foundations to make that easier.

@Noah-Kennedy
Copy link
Collaborator

Foundations doesn't use tracing, and instead has it's own competing system, but does handle all the stuff you are talking about here already, albeit the exporting is slightly hardcoded around jaeger OTEL, but that can easily be changed.

@ibotty
Copy link
Author

ibotty commented Feb 10, 2024

Sorry for the incomplete post.

Is there some documentation on why foundations is not using tokio's tracing? I would have hoped, that the enhancements in the blog post could be made in upstream tracing as well. It's a little unfortunate to not have the native tracing of tokio's crates.

@inikulin
Copy link
Collaborator

There is certain functionality in foundations that can't be implemented with tracing's design. Also, there are certain unresolved bugs in tracing that prevented it's adoption for certain scenarios that we have.

However, there's a plan to release an adapter crate that will allow funnelling of tracing-produced output to Foundations. cc @evanrittenhouse

@evanrittenhouse
Copy link
Contributor

Hopefully I can start work on the adapter crate in the next couple of days. I'm thinking we can start with an OTEL appender as shown in https://github.com/open-telemetry/opentelemetry-rust

@inikulin
Copy link
Collaborator

inikulin commented Mar 15, 2024

v4 will have native support for OTLP gRPC exporters for traces and logs.
Please, let me us know if you also need any of those:

  • OTLP HTTP endpoints support
  • Collectors requiring mTLS
  • OTLP support for metrics

@nifty-bytes
Copy link

+ for

  • OTLP HTTP endpoints support
  • OTLP support for metrics

@inikulin
Copy link
Collaborator

inikulin commented May 9, 2024

#34 adds support for OTLP tracing reporting. External reviews are vey much appreciated

@davidbarsky
Copy link

There is certain functionality in foundations that can't be implemented with tracing's design. Also, there are certain unresolved bugs in tracing that prevented it's adoption for certain scenarios that we have.

Hi! I'm a tracing maintainer. Can you share these limitations/bugs are? I'm not aware of what you're missing, but I'd like to be able to close those gaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants