Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Microsoft calendar event deletions from api to sync pods #425

Open
squeaky-pl opened this issue Nov 28, 2022 · 0 comments
Open

Move Microsoft calendar event deletions from api to sync pods #425

squeaky-pl opened this issue Nov 28, 2022 · 0 comments

Comments

@squeaky-pl
Copy link
Contributor

squeaky-pl commented Nov 28, 2022

In case of Google you can still fetch deleted events from the API even though they disappear in your calendar. In case of Microsoft they disappear both from the API and calendar, so they cannot be fetched in sync pods and synced there, the only way we can now something got deleted is in the webhook notifications.

To do less work (especially when cancelling recurrences with overrides) that could be potentially done in the background instead of marking events as cancelled directly in the api, store the uids of deleted events in a table event_cancellations(id PARIMARY KEY, calendar_id INT, uid TEXT, created_at DATETIME) and then change sync_events to fetch those events from database there, clone them, set as cancelled and then delete records from event_cancellations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant