Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detail pages linked from family return JSON #19

Closed
SimonGreenhill opened this issue Sep 29, 2020 · 14 comments
Closed

detail pages linked from family return JSON #19

SimonGreenhill opened this issue Sep 29, 2020 · 14 comments

Comments

@SimonGreenhill
Copy link

go here https://grambank.clld.org/familys and select a family. You are redirected to a JSON endpoint: https://grambank.clld.org/familys/utoa1244

Perhaps a better location is https://grambank.clld.org/languages with the family filter set correctly?

@SimonGreenhill
Copy link
Author

it would be quite nice to have a view for /languages/<family_id>/ which just shows the data points for family_id.

@xrotwang
Copy link
Member

xrotwang commented Sep 29, 2020

You mean a values table aggregating datapoints for all languages in the family? Is that actually useful? What would you expect to see there? If you think the map view would be useful, I'd rather propose we code feature values as icon shapes and family as color - this would provide a bit of classification info in all feature maps.

@SimonGreenhill
Copy link
Author

hmm, ok. I can see that people will want to drill down into the family level e.g. what do you have for UtoAztecan?

What about a view that solves #12 e.g. two panels -- one map and one features-on-a-tree? I guarantee that this would get screenshotted and included in a million talks :)

@xrotwang
Copy link
Member

xrotwang commented Sep 30, 2020 via email

@xrotwang
Copy link
Member

So https://grambank.clld.org/familys/utoa1244 has a map of the varieties and the table of coded values for all features (so far). Will have to think about where to put the tree with values for a single feature.

@xrotwang
Copy link
Member

Maybe the family details page will need a feature selection box and accept a URL parameter parameter=GB020. That would still be transparent and linkable enough, I'd think.

@SimonGreenhill
Copy link
Author

cool! thanks. I think the idea to have ?parameter=xxx will be very helpful.

@xrotwang
Copy link
Member

xrotwang commented Oct 2, 2020

So here's family page with tree and selectable features: https://grambank.clld.org/familys/algi1248?feature=GB022#tree-container

@SimonGreenhill
Copy link
Author

this is awesome, thanks @xrotwang ! one nitpick -- the 0's are quite hard to see, is it easy to up the contrast (reduce alpha?) or change the color?

@xrotwang
Copy link
Member

xrotwang commented Oct 2, 2020

Ah, yes. For maps with less dots the opacity doesn't make much sense.

@xrotwang
Copy link
Member

xrotwang commented Oct 2, 2020

Changing the colors is easy, too. Proposals? PRs?

@SimonGreenhill
Copy link
Author

sorry for bikeshedding, but what about https://colorbrewer2.org/#type=qualitative&scheme=Set1&n=4 or https://personal.sron.nl/~pault/ (actually fig 3 in the last link looks good, and is color blind friendly, so that would be nice).

Can we make:
? = gray cbbbbbb (is ? mapped? if not then don't worry)
0 = blue c0077bb
1 = red ccc3311
2 = teal c009988
3 = orange cee7733

@xrotwang
Copy link
Member

xrotwang commented Oct 2, 2020

@SimonGreenhill
Copy link
Author

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants