Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tagged releases to Docker Hub #12

Open
ruimarinho opened this issue Apr 19, 2016 · 8 comments
Open

Adding tagged releases to Docker Hub #12

ruimarinho opened this issue Apr 19, 2016 · 8 comments

Comments

@ruimarinho
Copy link
Collaborator

@clkao I think it's important to start tagging releases on github and auto building tags on Docker Hub so that users can pull the tagged release docker pull postgres-plv8:1.5.2 instead of latest.

WDYT?

@clkao
Copy link
Owner

clkao commented Apr 20, 2016

+1 on having plv8 point release tags on docker hub, but i think we still want to support different pg versions?

not sure about tagging in github though - doesn't seem to be what https://github.com/docker-library/postgres is doing. is there a docker source repo using tags?

@ruimarinho
Copy link
Collaborator Author

I guess those repositories haven't yet moved to the new system provided by Docker Hub, which lets you match git tags to build tags.

I was thinking something where Docker tagging looks like this: postgres-plv8:9.5-1.4.8, postgres-plv8:9.5-1.5.3, postgres-plv8:9.4-1.4.8, postgres-plv8:9.4-1.5.3.

The git counterpart tag would simply be the plv8 version for now (1.4.8), as we can change the Docker tag build name dynamically. This works because plv8 r1.4 and r1.5 both compile for postgres 9.4 and 9.5. When r2 is out, we will have to adjust the tag regex, but I think that's fine.

Docker Hub config (cannot add it myself):

Type: Tag
Name: ^1\.5\.[0-9.]+$
Dockerfile Location: /9.5-1.5
Docker Tag Name: 9.5-{sourceref}
Type: Tag
Name: ^1\.5\.[0-9.]+$
Dockerfile Location: /9.4-1.5
Docker Tag Name: 9.4-{sourceref}
Type: Tag
Name: ^1\.4\.[0-9.]+$
Dockerfile Location: /9.5-1.4
Docker Tag Name: 9.5-{sourceref}
Type: Tag
Name: ^1\.4\.[0-9.]+$
Dockerfile Location: /9.4-1.4
Docker Tag Name: 9.4-{sourceref}

@ruimarinho
Copy link
Collaborator Author

Any luck with these @clkao? I'm not sure how Docker Hub handles external collaborators, but I can help with this if you want and Docker Hub allows.

@ruimarinho
Copy link
Collaborator Author

Got any update on this @clkao?

@ruimarinho
Copy link
Collaborator Author

@clkao sorry to be a PITA, but do you have time to take a look at this soon?

@clkao
Copy link
Owner

clkao commented Aug 5, 2016

@ruimarinho Hi! sorry i've been busy. Looking into this now.

@clkao
Copy link
Owner

clkao commented Aug 5, 2016

it feels a bit painful that any logical change will go into multiple tags, and having tags not being immutable feels a bit icky. Unless there's a good way to programatically generate tag contents from a template (perhaps out of master), I think we should make the repo available as it is for the sake of clarify. also the postgis repo is havin the similar layout.

@ruimarinho
Copy link
Collaborator Author

@clkao indeed, it has that side affect but that will only affect the latest tag of each branch (9.X-1.X), which is considered mutable by default. All others depending on an explicit tag remain as static as we want them to be. It's hard to make mistakes with it, even if the setup is a bit convoluted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants