We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.1.48
Symptom joining two vectors works fine. joining two lists returns a vector not a list
Reproduction
(let [s "'[(1) (2)]" pos (pe/str-find-pos s 10) zloc (-> s (z/of-string {:track-position? true}) (z/find-last-by-pos {:row 1 :col 7}))] (-> (paredit/join zloc) (z/root-string)))
Diagnosis The source for paredit/join appears to have :vector hard coded in.
Action Maybe just take the tag type of the right. Also maybe ensure they are both of the same tag type?
Less of a concern is that if there is not a whitespace, it appears to merge the two items e.g. [[foo][bar]] comes back as [[foobar]] not [[foo bar]].
I can git up a pr on this but I don't know if you would consider it a breaking change for some things.
Thx again repl-balance is near feature complete on paredit thanks to rewrite-clj!
The text was updated successfully, but these errors were encountered:
Thanks for the issue, @openvest!
I've got a bunch of paredit fixes in the hopper, and this happens to be one of them!
Sorry, something went wrong.
No branches or pull requests
Version
1.1.48
Symptom
joining two vectors works fine.
joining two lists returns a vector not a list
Reproduction
Diagnosis
The source for paredit/join appears to have :vector hard coded in.
Action
Maybe just take the tag type of the right. Also maybe ensure they are both of the same tag type?
Less of a concern is that if there is not a whitespace, it appears to merge the two items e.g. [[foo][bar]] comes back as [[foobar]] not [[foo bar]].
I can git up a pr on this but I don't know if you would consider it a breaking change for some things.
Thx again repl-balance is near feature complete on paredit thanks to rewrite-clj!
The text was updated successfully, but these errors were encountered: