Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using pre-commit as a tool to setup pre-commit hooks #363

Open
AntoineRondelet opened this issue Apr 1, 2021 · 0 comments
Open

Consider using pre-commit as a tool to setup pre-commit hooks #363

AntoineRondelet opened this issue Apr 1, 2021 · 0 comments
Labels
code-quality Task related to the code quality (refactor, enhancements etc.) good first issue Good for newcomers tooling Task related to the tooling used in the repository

Comments

@AntoineRondelet
Copy link
Contributor

As per the title, it wouldn't hurt to add more git hooks to this repo, especially pre-commit ones to make sure no style violation happens within commits, and to catch such hiccups asap instead of waiting for the CI to fail.
The pre-commit tool looks like a good way to manage various pre-commit hooks, so it may be interesting to look into adding support for this tool later down the line.
@AntoineRondelet AntoineRondelet added good first issue Good for newcomers code-quality Task related to the code quality (refactor, enhancements etc.) tooling Task related to the tooling used in the repository labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Task related to the code quality (refactor, enhancements etc.) good first issue Good for newcomers tooling Task related to the tooling used in the repository
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AntoineRondelet