diff --git a/modules/integration_aws-backup/README.md b/modules/integration_aws-backup/README.md index 4f4f43f43..718fd0c6c 100644 --- a/modules/integration_aws-backup/README.md +++ b/modules/integration_aws-backup/README.md @@ -23,9 +23,8 @@ existing [stack](https://github.com/claranet/terraform-signalfx-detectors/wiki/G module "signalfx-detectors-integration-aws-backup" { source = "github.com/claranet/terraform-signalfx-detectors.git//modules/integration_aws-backup?ref={revision}" - environment = var.environment - notifications = local.notifications - aws_account_id = "fillme" + environment = var.environment + notifications = local.notifications } ``` @@ -58,7 +57,7 @@ Note the following parameters: These 3 parameters along with all variables defined in [common-variables.tf](common-variables.tf) are common to all [modules](../) in this repository. Other variables, specific to this module, are available in -[variables.tf](variables.tf) and [variables-gen.tf](variables-gen.tf). +[variables-gen.tf](variables-gen.tf). In general, the default configuration "works" but all of these Terraform [variables](https://www.terraform.io/language/values/variables) make it possible to customize the detectors behavior to better fit your needs. diff --git a/modules/integration_aws-backup/common-filters.tf b/modules/integration_aws-backup/common-filters.tf index 9c7655eb2..3b64c4339 100644 --- a/modules/integration_aws-backup/common-filters.tf +++ b/modules/integration_aws-backup/common-filters.tf @@ -7,5 +7,5 @@ # and alerts, since CloudWatch returns aggregated metric, and per vault and # resource type. locals { - filters = format("filter('namespace', 'AWS/Backup') and filter('stat', 'sum') and filter('BackupVaultName', '*', match_missing=False) and filter('ResourceType', '*', match_missing=False) and filter('aws_account_id', '%s')", var.aws_account_id) + filters = "filter('namespace', 'AWS/Backup') and filter('stat', 'sum') and filter('BackupVaultName', '*', match_missing=False) and filter('ResourceType', '*', match_missing=False)" } diff --git a/modules/integration_aws-backup/variables.tf b/modules/integration_aws-backup/variables.tf deleted file mode 100644 index b4753f0f3..000000000 --- a/modules/integration_aws-backup/variables.tf +++ /dev/null @@ -1,3 +0,0 @@ -variable "aws_account_id" { - type = string -}