Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font color picker not working properly on first change #17069

Open
jessna96 opened this issue Sep 10, 2024 · 2 comments · May be fixed by #17109
Open

Font color picker not working properly on first change #17069

jessna96 opened this issue Sep 10, 2024 · 2 comments · May be fixed by #17109
Assignees
@Mati365
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:font type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jessna96
Copy link

📝 Provide detailed reproduction steps (if any)

  1. Go to https://ckeditor.com/docs/ckeditor5/latest/features/font.html#demo
  2. Select any text in the editor (for example "message").
  3. Click on the font color icon in the toolbar and select the "color picker".
  4. Click in the right upper corner of the color gradient field.
  5. Then select any other color in the gradient field.
  6. Save the font color with the green check.

✔️ Expected result

The color selected the second time (step 5) is applied to the selected text.

❌ Actual result

The first color is applied to the selected text (the one selected in step 4).

❓ Possible solution

📃 Other details

This only happens the very first time the font color picker is used after loading the page (going into editor mode of the ckEditor).
Further it only happens in Chrome and Edge.

  • Browser: Chrome
  • OS: macOS Sonoma 14.6.1
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@jessna96 jessna96 added the type:bug This issue reports a buggy (incorrect) behavior. label Sep 10, 2024
@Witoso Witoso added package:font domain:ui/ux This issue reports a problem related to UI or UX. labels Sep 10, 2024
@Witoso
Copy link
Member

Witoso commented Sep 10, 2024

@ckeditor/qa-team would you mind verifying if this is a recent regression?

@Mati365 Mati365 self-assigned this Sep 17, 2024
@Mati365
Copy link
Member

Mati365 commented Sep 17, 2024 •
edited
Loading

I managed to reproduce it on Linux/Chrome 128, however it's not possible to reproduce that on Firefox 130. Not a recent regression - I checked it to 36.0.0 version. I'll take a look.

Notes:

⚠️ It looks like selection is wrongly applied to partially selected text on Chrome after first change of color:

Before

obraz

After

obraz

So second change of color results in:

obraz

Although model seems to have wrong color attribute applied:

obraz

On the Firefox selection is restored properly:

obraz

@Mati365 Mati365 linked a pull request Sep 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mati365 Mati365

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:font type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix font color picker not working properly on first change on Chrome ckeditor/ckeditor5
3 participants
@Mati365 @Witoso @jessna96