Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page layout breaks if editor is maximized and you navigate back in browser #8

Closed
Dumluregn opened this issue Oct 1, 2020 · 3 comments
Labels
resolution:upstream Issue in the third-party software. status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@Dumluregn
Copy link
Contributor

This issue is already reported in both Angular and Vue integrations, probably exists also in React one, which makes fixing it a good candidate for the next common util.

Originally reported in Angular:
ckeditor/ckeditor4-angular#141

Checked and confirmed in Vue:
ckeditor/ckeditor4-vue#64

@Dumluregn Dumluregn added workload:medium status:confirmed An issue confirmed by the development team. type:feature A feature request. and removed workload:medium labels Oct 1, 2020
@f1ames
Copy link
Contributor

f1ames commented Oct 9, 2020

This one is generally related to how maximize works - it is an issue with every SPA application basically. So I think:

  1. There should be a way API to "demaximize" editor so custom integrations could use to fix this issue (not sure it will require any changes in CKEditor 4 itself or calling maximize second time does the job).
  2. Official integrations should have built-in mechanism using the above so it works out of the box.

@f1ames
Copy link
Contributor

f1ames commented Oct 9, 2020

Ok, I see maximize command works both ways 👍

@f1ames
Copy link
Contributor

f1ames commented Nov 16, 2020

We decided to try to cover it in CKEditor 4 itself. In an unlikely event that it will not be possible we could try to cover it here.

@f1ames f1ames closed this as completed Nov 16, 2020
@f1ames f1ames added size:External resolution:upstream Issue in the third-party software. and removed size:M labels Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:upstream Issue in the third-party software. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

2 participants