-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements from Queensland Government fork #70
base: master
Are you sure you want to change the base?
Conversation
- This uses the external URL without an API key, so it will not work on private datasets, but it is otherwise fairly reliable.
…s an upload - This appears to point to either the download URL, or the cache URL, as needed
- add Flake8 config and make it pass - use 'six' to prepare for Python 3
- patch xlrd - don't force versions of ckanext-archiver and ckanext-report, just verify they're present
… text vs binary typing
- new minor version, because it introduces the download proxy and retrieving remote cached files as new features
- install newer setuptools if needed - install transitive dependencies of ckanext-archiver and ckanext-report - start to recognise Python 3
For some reason the CKAN versions aren't being respected and it's always running against master. Will look into what's needed to make it compatible with CKAN 2.9.x. |
I'll probably have time in the near future to migrate QA to py3, some of these changes are probably done during that. Travis will be replaced by Github Actions, so I wouldn't use too much time maintaining travis scripts. |
We made a start on converting to GitHub actions, and some of the resulting test fixes are in this pull request, but I wasn't able to make the last few tests pass (it was failing to determine the type of some of the sample files, for no reason I could identify, but it was consistent). I can submit our workflow if you want to review it. |
- needs a bit more debugging but is close to working
Hi @ThrawnCA and @Zharktas, are you guys planning on using this PR to do the PY3 and CKAN upgrades? My team (GSA/data.gov) is in the process of upgrading our applications to PY3 and CKAN 2.9 and since this is a dependency, I was curious if there were any updates on either of your ends regarding additional work here. I'd be happy to support the upgrade based on the current progress. In the coming weeks, we will be ramping up activity in this specific upgrade. |
Actually, my organisation has a fork of this extension, https://github.com/qld-gov-au/ckanext-qa, which is what we'll use for upgrading. This PR is just backporting some of our changes to upstream.
There's a project happening right now that's putting the upgrade on hold at our end, but in a few months we'll likely focus on it in earnest. Sounds like you'll probably be done by then. Probably best if you collaborate with Zharktas. |
file
fallback more consistently when other methods fail.requirements.txt
instead ofsetup.py
.