Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

District and wonder placement highlights don't disappear upon exiting placement mode #370

Open
davidm88 opened this issue Sep 23, 2024 · 1 comment

Comments

@davidm88
Copy link

Describe the bug
When I select a wonder or district to place in a city, the available plots are highlighted. When I right click to cancel placement mode, the plot highlight remains until I exit the city view. I can correlate this issue to an error in Lua.log, but I have also found 2 other issues which I can reproduce in the provided save file. One is that locking a tile in the city view doesn't change it from orange to green until I close and re-open the city view (it used to do this straight away), and the other is that selecting (in particular) the city overlap and resource lenses will not cause an issue in the game but will print an error message in the log of the same function as the plot highlight error.

To Reproduce
Plot highlight:

  • Open the save file with only CQUI enabled (I played the game with tons of mods but have tested it with just CQUI)
  • Open the city view of Nidaros (captial)
  • Select a district or a wonder
  • The available plots are highlighted
  • Right click to cancel placement mode
  • The plots are still highlighted
  • Error in the Lua.log file:
    PlotInfo: PlotInfo::OnCitySelectionChanged 0 65536 58 20 0 true false MinimapPanel: ERROR: SetModLens - Given lens 'NONE' has no entry PlotInfo: PlotInfo::OnCitySelectionChanged 0 65536 0 0 0 false false
    Worked tile colours:
  • Open the city view of Nidaros
  • Lock a tile that's currently orange
    City Overlap Lens:
  • Select the city overlap lens
    MinimapPanel: ERROR: SetModLens - No Plot Color Function for ML_CITYOVERLAP
    Resource Lens:
  • Select the resource lens
    MinimapPanel: Show Resource Picker MinimapPanel: ERROR: SetModLens - No Plot Color Function for ML_RESOURCE
    Expected behavior
    Plot highlight:
  • The plots should not be highlighted after right clicking (exiting placement mode)
    Worked tile colours:
  • The tile should go bright green when locked immediately instead of having to close and re-open the city view
    City Overlap Lens:
  • Working fine, just produces an error in the log
    Resource Lens:
  • Working fine, just produces an error in the log

Screenshots
Here, I have exited placement mode (the only difference I can see is that the city details in the bottom right have re-appeared, they seem to disappear when placing), and the plot is still highlighted:
https://imgur.com/j2s8Ihj

Save game and logs
mod test.zip

@davidm88
Copy link
Author

I'd like to add, this doesn't seem to happen early on, and I tested this by starting up a new game with only CQUI, and then rushed Astrology and tried to place a Holy Site. I don't get the plot highlight issue there, but it always seems to pop up later in the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant