Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging multiple files in folder fails in windows #170

Open
Mboga opened this issue Aug 28, 2023 · 6 comments
Open

Merging multiple files in folder fails in windows #170

Mboga opened this issue Aug 28, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@Mboga
Copy link

Mboga commented Aug 28, 2023

Describe the bug
Running the merge command on a list of files in a folder fails in windows. The output of the command is a warning that there are no files to merge. However, the same command runs successfully in linux.

cjio model.city.json merge "'./test/*.city.json'" save test_58m.city.json

cjio v0.8.1; supports CityJSON v1.1
Windows 10

@hugoledoux
Copy link
Member

hugoledoux commented Sep 11, 2023

I don't have windows to test, but could you try with backslashes and not use a relative path?

cjio model.city.json merge "C:\temp\*.city.json" save test_58m.city.json

@Mboga
Copy link
Author

Mboga commented Sep 12, 2023

Thank you for your reply:
I have four files to merge ''tile_58_2.city.json,tile_58_3.city.json,tile_58_4.city.json,tile_58_5.city.json"
When I run this on windows, I get an error:

cjio model.city.json merge "C:\temp\tile_58_post*.city.json" save test_58m.city.json
Usage: cjio [OPTIONS] INPUT COMMAND1 [ARGS]... [COMMAND2 [ARGS]...]...
Try 'cjio --help' for help.

Error: No such command 'C:\temp\tile_58_post\tile_58_5.city.json'.

@hugoledoux
Copy link
Member

sorry single quotes then + not sure we resolves with tile_58_post as prefix... try just *.json?

cjio model.city.json merge 'C:\temp\*.city.json' save test_58m.city.json

@Mboga
Copy link
Author

Mboga commented Sep 12, 2023

Thanks for your reply I have tried *.json in the first test. Sorry tile_58_post was a typo when writing in the comment section. It is the folder that contains the individual .city.json files to be merged. Thank you

cjio model.city.json merge 'C:\temp\tile_58_post\tile_58_post\*.json' save test_58m.city.json
Parsing model.city.json
Merging files
WARNING: No files to merge.
Saving CityJSON to a file C:\temp\tile_58_post\test_58m.city.json

cjio model.city.json merge 'C:\temp\tile_58_post\*.city.json' save test_58m.city.json
Parsing model.city.json
Merging files
WARNING: No files to merge.
Saving CityJSON to a file C:\temp\test_58m.city.json

cjio model.city.json merge "'C:\temp\tile_58_post\tile_58_post\*.json'" save test_58m.city.json
Parsing model.city.json
Merging files
WARNING: No files to merge.
Saving CityJSON to a file C:\temp\test_58m.city.json``

@hugoledoux
Copy link
Member

okay, clearly something is wrong with Windows, I'll try to find a Windows machine and fix this!

@hugoledoux hugoledoux self-assigned this Sep 12, 2023
@hugoledoux hugoledoux added the bug Something isn't working label Sep 12, 2023
@dezemberwxnd
Copy link

Has there been a fix to this issue yet? Seeing that this issue is still open, i figure that there is not. Is there any workaround or a system on which this works?
kind regards and thank you in advance for anyone answering :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants