Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit font-loading strategy #1402

Open
davidsauntson opened this issue Aug 5, 2021 · 0 comments
Open

Revisit font-loading strategy #1402

davidsauntson opened this issue Aug 5, 2021 · 0 comments
Labels
tech debt Technical tasks that would usually form a contribution

Comments

@davidsauntson
Copy link
Contributor

Our current font-loading strategy is a bit awkward. Relying on resolve-url-loader in order to resolve fonts.

It’s also pretty broken if you try and use the built CSS version e.g. https://unpkg.com/@citizensadvice/[email protected]/lib/lib.css as it assumes fonts existing at a top-level /fonts directory but has no access to those files.

Maybe something like govuk-frontend’s $govuk-fonts-path or excluding fonts from the built CSS version with instructions on how to load them would work?

Could be as simple as documenting more options for loading fonts. Maybe we revisit this once we’ve moved away from icon fonts?
@davidsauntson davidsauntson added the tech debt Technical tasks that would usually form a contribution label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Technical tasks that would usually form a contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidsauntson