Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add labeled_by filter #92

Open
misaka opened this issue Mar 13, 2024 · 1 comment
Open

Feature request: add labeled_by filter #92

misaka opened this issue Mar 13, 2024 · 1 comment

Comments

@misaka
Copy link

misaka commented Mar 13, 2024

Hi all.

I just discovered this package while migrating some tests from Playwright to Capybara, and it really looks nice! Thank you for sharing it!

The described_by filter seems particularly handy for writing tests without relying too directly on the HTML structure. In our project, however, we're using a component that uses the labeledby ARIA attribute which, I think, could work the same way.

Would adding a labeled_by filter that functions similar to described_by make sense? I'd also be up for taking a stab at adding it if so.

Cheers!

@seanpdoyle
Copy link
Contributor

Conceptually, is labeled_by backed by the aria-labelledby attribute? If that's the case, would the newer accessible_name cover that style of filtering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants