-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text review & related UX: invitation expiry #287
Comments
I would say let's get rid of the "oops" because that's what makes it sound accidental/a mistake. But I would keep the "apologise for inconvenience", that's just being considerate :) Good point. I don't know how you can request to access a topic that is not visible for you since it's private...? And if it's public there's no need to request... I am a bit confused :D |
@kevincrepin Ok thank you! Will remove the Oops :) |
And if it's not currently possible to request another invite (unless you have their email address already somehow), should we build in the possibility to do so at some point? Could be quite a simple button on the email potentially, the clicking of which notifies the person who sent it to send it again? |
In the first point I agree with both of you @kevincrepin and @BeccaMelhuish and I would even took both (oops! and apology) out and leave only: Regarding the expiration of the invitation, I already questioned in its necessity a few months ago after a user asked why invitations expire and only good reason I could bring was that it´s for the safety reasons (if baddies get access to your email account, then they can log in to the topic/group). |
Just came here to ask the same thing - what's the reason for expiration? Invite emails don't expire in other services I use (unless invite revoked or content deleted), so we probably shouldn't, either - it's a pretty frustrating experience for the user. |
Had the same thought when I first discovered it (I never knew they expired, and also don't see the reason for it). But maybe @kevincrepin or @ilmartyrk know of a good reason for it? |
I don't have any good reason why they expire. Original issue with the discussion is here citizenos/citizenos-fe-old#112 |
Thanks @ilmartyrk. This is what I caught from the issue citizenos/citizenos-fe-old/issues/112 thread: Mikk: IF we're showing latest info in the invite UI, we need to create an access token for the Topic information. That token cannot live forever. How long do you think it makes sense for an invitation to be valid? I would think if you haven't reacted 14 days, it should expire. The inviter can always send a new invite. We MAY want to implement expired invitation flow where you can re-request access, but that would create significant amount of UX and BE work. BUT, overall the feature of requesting an access makes sense to me. You MAY want to request access to edit a public topic? @ilmartyrk this decision has technical reason? IF we're showing latest info in the invite UI, we need to create an access token for the Topic information. That token cannot live forever I understand it´s because the token must expire? Otherwise I don´t see any strong arguments for invitations to expire in 14 days AND Users are also confused for this behavior. So, I would propose that invite emails would not expire after 14 days, but if the token needs to expire then it would expire after 90 days or something like that? WDYT? |
Lets change the expiration time to 30 days. |
Agreed with @ssin1901 to move this to 'next' due to this causing some significant inconvenience for a General Assembly admin, plus it should be a quick fix (we assume). User insight (for the record): |
Dev task summary:
|
@kevincrepin @ilmartyrk @anettlinno @oksks
A couple of thoughts re these strings below:
("Oops! This invitation has expired. We apologise for the inconvenience. You may try requesting access to this topic again."
"Oops! This invitation has expired. We apologise for the inconvenience. You may try requesting access to this group again.")
The text was updated successfully, but these errors were encountered: