BUG: A bunch of active strings are lacking texts

[oksks]

What is the problem?
A bunch of active strings appear as keys in my activity feed.
Please see the 4 screenshots below - all taken today.

Why is this a problem?
This looks (and is) broken and leaves a negative impression of our product.

Possible solution.
Please add copy to strings.

[tiblu]

@oksks Problem is not the missing translations, but I think I have broken the way activities are generated with #112 deployment.

The code is using field type instead of @type to generate the translation key.

{
   "status":{
      "code":20000
   },
   "data":[
      {
         "id":"bc13abfd-c0b3-4cf2-8186-6b7c9e40c446",
         "data":{
            "type":"Update",
            "actor":{
               "id":"b0e6e3d2-4b86-4656-a406-90866003c972",
               "name":"Mikk",
               "type":"User",
               "company":"CitizenOS"
            },
            "object":{
               "id":"2be1e360-cc63-4c6d-96c7-3d4f44e03418",
               "text":"Add a PRO argument TEXT",
               "type":"pro",
               "@type":"Comment",
               "edits":[
                  {
                     "text":"Add a PRO argument TEXT",
                     "type":"pro",
                     "subject":"Add a PRO argument SUBJ",
                     "createdAt":"2019-11-20T15:13:53.855+00:00"
                  },
                  {
                     "text":"UPDATE Add a PRO argument TEXT",
                     "type":"pro",
                     "subject":"UPDATE Add a PRO argument SUBJ",
                     "createdAt":"2019-11-20T15:14:33+00:00"
                  }
               ],
               "parent":{
                  "id":"2be1e360-cc63-4c6d-96c7-3d4f44e03418",
                  "version":0
               },
               "report":{
                  "id":null
               },
               "creator":{
                  "id":"b0e6e3d2-4b86-4656-a406-90866003c972"
               },
               "subject":"Add a PRO argument SUBJ",
               "createdAt":"2019-11-20T15:13:53.855Z",
               "deletedAt":null,
               "deletedBy":{
                  "id":null
               },
               "updatedAt":"2019-11-20T15:13:53.855Z",
               "deletedReasonText":null,
               "deletedReasonType":null
            },
            "origin":{
               "id":"2be1e360-cc63-4c6d-96c7-3d4f44e03418",
               "text":"Add a PRO argument TEXT",
               "type":"pro",
               "@type":"Comment",
               "edits":[
                  {
                     "text":"Add a PRO argument TEXT",
                     "type":"pro",
                     "subject":"Add a PRO argument SUBJ",
                     "createdAt":"2019-11-20T15:13:53.855+00:00"
                  },
                  {
                     "text":"UPDATE Add a PRO argument TEXT",
                     "type":"pro",
                     "subject":"UPDATE Add a PRO argument SUBJ",
                     "createdAt":"2019-11-20T15:14:33+00:00"
                  }
               ],
               "parent":{
                  "id":"2be1e360-cc63-4c6d-96c7-3d4f44e03418",
                  "version":0
               },
               "report":{
                  "id":null
               },
               "creator":{
                  "id":"b0e6e3d2-4b86-4656-a406-90866003c972"
               },
               "subject":"Add a PRO argument SUBJ",
               "createdAt":"2019-11-20T15:13:53.855Z",
               "deletedAt":null,
               "deletedBy":{
                  "id":null
               },
               "updatedAt":"2019-11-20T15:13:53.855Z",
               "deletedReasonText":null,
               "deletedReasonType":null
            },
            "result":[
               {
                  "op":"replace",
                  "path":"/subject",
                  "value":"UPDATE Add a PRO argument SUBJ"
               },
               {
                  "op":"replace",
                  "path":"/text",
                  "value":"UPDATE Add a PRO argument TEXT"
               }
            ],
            "target":{
               "id":"582d81dc-fe8d-40c7-b583-a82f0a0047cb",
               "title":"Topic invites live test 3 - #112",
               "status":"inProgress",
               "visibility":"private",
               "tokenJoin":"l93M317B",
               "categories":[

               ],
               "padUrl":"https://p.citizenos.com/p/582d81dc-fe8d-40c7-b583-a82f0a0047cb",
               "sourcePartnerId":null,
               "sourcePartnerObjectId":null,
               "endsAt":null,
               "hashtag":null,
               "createdAt":"2019-11-20T13:58:03.231Z",
               "updatedAt":"2019-11-20T14:33:17.414Z",
               "@type":"Topic",
               "creatorId":"b0e6e3d2-4b86-4656-a406-90866003c972"
            },
            "context":"PUT /api/users/self/topics/582d81dc-fe8d-40c7-b583-a82f0a0047cb/comments/2be1e360-cc63-4c6d-96c7-3d4f44e03418"
         },
         "createdAt":"2019-11-20T15:14:33.667Z",
         "updatedAt":"2019-11-20T15:14:33.668Z",
         "deletedAt":null
      },
      {
         "id":"7082cf48-7fff-493b-989b-550738dbb074",
         "data":{
            "type":"Create",
            "actor":{
               "id":"b0e6e3d2-4b86-4656-a406-90866003c972",
               "name":"Mikk",
               "type":"User",
               "company":"CitizenOS"
            },
            "object":{
               "id":"bf186da0-b0f9-4bc3-833d-ec0c9d9a27f1",
               "text":"Add a CON argument TEXT",
               "type":"con",
               "@type":"Comment",
               "edits":[
                  {
                     "text":"Add a CON argument TEXT",
                     "type":"con",
                     "subject":"Add a CON argument SUBJ",
                     "createdAt":"2019-11-20T15:14:14+00:00"
                  }
               ],
               "parent":{
                  "id":"bf186da0-b0f9-4bc3-833d-ec0c9d9a27f1",
                  "version":0
               },
               "report":{
                  "id":null
               },
               "creator":{
                  "id":"b0e6e3d2-4b86-4656-a406-90866003c972"
               },
               "subject":"Add a CON argument SUBJ",
               "createdAt":"2019-11-20T15:14:14.923Z",
               "deletedAt":null,
               "deletedBy":{
                  "id":null
               },
               "updatedAt":"2019-11-20T15:14:14.923Z",
               "deletedReasonText":null,
               "deletedReasonType":null
            },
            "target":{
               "id":"582d81dc-fe8d-40c7-b583-a82f0a0047cb",
               "title":"Topic invites live test 3 - #112",
               "status":"inProgress",
               "visibility":"private",
               "tokenJoin":"l93M317B",
               "categories":[

               ],
               "padUrl":"https://p.citizenos.com/p/582d81dc-fe8d-40c7-b583-a82f0a0047cb",
               "sourcePartnerId":null,
               "sourcePartnerObjectId":null,
               "endsAt":null,
               "hashtag":null,
               "createdAt":"2019-11-20T13:58:03.231Z",
               "updatedAt":"2019-11-20T14:33:17.414Z",
               "@type":"Topic",
               "creatorId":"b0e6e3d2-4b86-4656-a406-90866003c972"
            },
            "context":"POST /api/users/self/topics/582d81dc-fe8d-40c7-b583-a82f0a0047cb/comments"
         },
         "createdAt":"2019-11-20T15:14:14.969Z",
         "updatedAt":"2019-11-20T15:14:14.971Z",
         "deletedAt":null
      },
      {
         "id":"6141f9fe-a8d7-44dc-81a2-428cb0acf608",
         "data":{
            "type":"Create",
            "actor":{
               "id":"b0e6e3d2-4b86-4656-a406-90866003c972",
               "name":"Mikk",
               "type":"User",
               "company":"CitizenOS"
            },
            "object":{
               "id":"2be1e360-cc63-4c6d-96c7-3d4f44e03418",
               "text":"Add a PRO argument TEXT",
               "type":"pro",
               "@type":"Comment",
               "edits":[
                  {
                     "text":"Add a PRO argument TEXT",
                     "type":"pro",
                     "subject":"Add a PRO argument SUBJ",
                     "createdAt":"2019-11-20T15:13:53+00:00"
                  }
               ],
               "parent":{
                  "id":"2be1e360-cc63-4c6d-96c7-3d4f44e03418",
                  "version":0
               },
               "report":{
                  "id":null
               },
               "creator":{
                  "id":"b0e6e3d2-4b86-4656-a406-90866003c972"
               },
               "subject":"Add a PRO argument SUBJ",
               "createdAt":"2019-11-20T15:13:53.855Z",
               "deletedAt":null,
               "deletedBy":{
                  "id":null
               },
               "updatedAt":"2019-11-20T15:13:53.855Z",
               "deletedReasonText":null,
               "deletedReasonType":null
            },
            "target":{
               "id":"582d81dc-fe8d-40c7-b583-a82f0a0047cb",
               "title":"Topic invites live test 3 - #112",
               "status":"inProgress",
               "visibility":"private",
               "tokenJoin":"l93M317B",
               "categories":[

               ],
               "padUrl":"https://p.citizenos.com/p/582d81dc-fe8d-40c7-b583-a82f0a0047cb",
               "sourcePartnerId":null,
               "sourcePartnerObjectId":null,
               "endsAt":null,
               "hashtag":null,
               "createdAt":"2019-11-20T13:58:03.231Z",
               "updatedAt":"2019-11-20T14:33:17.414Z",
               "@type":"Topic",
               "creatorId":"b0e6e3d2-4b86-4656-a406-90866003c972"
            },
            "context":"POST /api/users/self/topics/582d81dc-fe8d-40c7-b583-a82f0a0047cb/comments"
         },
         "createdAt":"2019-11-20T15:13:53.917Z",
         "updatedAt":"2019-11-20T15:13:53.919Z",
         "deletedAt":null
      }
   ]
}

[tiblu]

@oksks Fixed! Thanks for reporting!
The issue was a regression of citizenos/citizenos-fe#112

We should introduce a solution where if a translation key has no translation, we hide the activity BUT report it to the back-end so that developers can fix it. We have no reporting solution tho - we used to have Sentry, but never really tracked it.

[loorm]

Tested. Confirmed.