Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-mails: Drop usage of campaign-mailgun, use SMTP instead #47

Closed
2 tasks
tiblu opened this issue Nov 15, 2018 · 5 comments
Closed
2 tasks

E-mails: Drop usage of campaign-mailgun, use SMTP instead #47

tiblu opened this issue Nov 15, 2018 · 5 comments
Assignees
Labels
enhancement Making an existing feature better. good first issue Good for newcomers.

Comments

@tiblu
Copy link
Member

tiblu commented Nov 15, 2018

Overview

campaign-mailgun uses Mailgun API, but Mailgun can be used over SMTP so it provides no extra value.
Rather, it provides extra problems - the Campaign switches on e-mail tracking which rewrites links in the e-mails.

TODO

  • Drop usage of campaign-mailgun
  • Configure servers to use campaign over SMTP
@tiblu tiblu added enhancement Making an existing feature better. good first issue Good for newcomers. labels Nov 15, 2018
@ilmartyrk
Copy link
Member

Still relevant. campaing-mailgun also has some deprecated packages and functions too just to make this task more relevant

@ilmartyrk
Copy link
Member

possible library to use https://github.com/mailgun/mailgun.js

@anettlinno
Copy link

Triage 37. Current campaign-mailgun is outdated and needs to be updated to what Ilmar proposed above.
Approx. dev. time 1 day. Sending to development.

@ilmartyrk ilmartyrk self-assigned this Jan 24, 2022
@ilmartyrk
Copy link
Member

Update campaign and related packages, created pull requests. All in all it is really good library. Fixed all related packages too. Hopefully pull requests are accepted and we can revert back to getting packages from npm. But if that will not happen in recent month or so will create our own release or merge this directly to our code.

ilmartyrk added a commit that referenced this issue Jan 28, 2022
@ilmartyrk
Copy link
Member

Added test coverage for all our current e-mails but these would need to be more thorough, created a new issue for that as it is not with so high priority #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making an existing feature better. good first issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

3 participants