Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECHNICAL DEPT: Topic / Group invites - remove "auto-accept" invite API interfaces #203

Closed
5 tasks done
tiblu opened this issue May 4, 2021 · 2 comments
Closed
5 tasks done
Assignees
Labels
technical dept. Ugly solutions for quick wins - https://en.wikipedia.org/wiki/Technical_debt

Comments

@tiblu
Copy link
Member

tiblu commented May 4, 2021

What?

As part of citizenos/citizenos-fe#112 and citizenos/citizenos-fe#348 User MUST accept invite in order to join a Topic / Group. This supersedes the solution where User was automatically added to the Topic / Group.

TODO

  • Remove all "auto-accept" related API interfaces and tests. Careful tho! Some of the /members interfaces are still used and are valid, not all of them are to go. Verify usage against logs.
  • Verify if GET /api/invite/view is still used, REMOVE IF NOT. Used by adding topic to group
  • Verify Citizen OS Topic / Group invite flows still work.
  • Pump major version of Citizen OS API
  • Update API changelog to reflect the change.

Related to:

@loorm
Copy link
Member

loorm commented May 18, 2021

Triage 37. Estimated dev time 6 hours. Prioritizing.

@ilmartyrk ilmartyrk self-assigned this Jun 2, 2021
@ilmartyrk
Copy link
Member

FIXED by c98bf93 This turned out to be a bigger task, as I decided to update all tests too as there were quite many related to removed code. Also this helped to make tests running to be more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical dept. Ugly solutions for quick wins - https://en.wikipedia.org/wiki/Technical_debt
Projects
None yet
Development

No branches or pull requests

3 participants