-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(natives/interior): update interiors natives/examples #1104
base: master
Are you sure you want to change the base?
Conversation
spacevx
commented
May 7, 2024
- Update PIN_INTERIOR_IN_MEMORY
- Update IS_INTERIOR_ENTITY_SET_ACTIVE
- Update ENABLE_SHADOW_CULL_MODEL_THIS_FRAME
- Update ENABLE_EXTERIOR_CULL_MODEL_THIS_FRAME
- Update DISABLE_METRO_SYSTEM
- Update DEACTIVATE_INTERIOR_ENTITY_SET
- Update ACTIVATE_INTERIOR_ENTITY_SET
@4mmonium any news? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the most part, requested some changes though.
``` | ||
More info: http://gtaforums.com/topic/836367-adding-props-to-interiors/ | ||
NativeDB Introduced: v323 | ||
More info: https://gtaforums.com/topic/836367-adding-props-to-interiors/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldnt use external links - always refer to FiveM docs itself (if it's not there, you can PR then add the link after its merge)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link doesn't provide much information, so it would probably be best to just remove it.
``` | ||
This is the native that is used to hide the exterior of GTA Online apartment buildings when you are inside an apartment. | ||
NativeDB Introduced: v323 | ||
More info: https://gtaforums.com/topic/836301-hiding-gta-online-apartment-exteriors/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this link too
``` | ||
More info: http://gtaforums.com/topic/836367-adding-props-to-interiors/ | ||
NativeDB Introduced: v323 | ||
More info: https://gtaforums.com/topic/836367-adding-props-to-interiors/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link doesn't provide much information, so it would probably be best to just remove it.
CreateThread(function() | ||
local interiorID = GetInteriorAtCoords(976.6364, 70.29476, 115.1641) | ||
PinInteriorInMemory(interiorID) | ||
repeat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be best do do something below this while loop to show why you should wait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean like this?
CreateThread(function()
-- Coordinates of the interior
local interiorID = GetInteriorAtCoords(976.6364, 70.29476, 115.1641)
-- Load the interior into memory
PinInteriorInMemory(interiorID)
-- Wait until the interior is ready
repeat
Wait(0)
until IsInteriorReady(interiorID)
-- Teleport the player to the interior
local playerPed = PlayerPedId()
SetEntityCoords(playerPed, 976.6364, 70.29476, 115.1641)
end)
@AvarianKnight Updated, it should be better now |
``` | ||
This is the native that is used to hide the exterior of GTA Online apartment buildings when you are inside an apartment. | ||
NativeDB Introduced: v323 | ||
More info: https://gtaforums.com/topic/836301-hiding-gta-online-apartment-exteriors/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this link too
* Update PIN_INTERIOR_IN_MEMORY * Update IS_INTERIOR_ENTITY_SET_ACTIVE * Update ENABLE_SHADOW_CULL_MODEL_THIS_FRAME * Update ENABLE_EXTERIOR_CULL_MODEL_THIS_FRAME * Update DISABLE_METRO_SYSTEM * Update DEACTIVATE_INTERIOR_ENTITY_SET * Update ACTIVATE_INTERIOR_ENTITY_SET refactor(example): set the player into the interior * In the example of PinMemory when the interior is ready we are now teleporting the player in the interior * Removed the gtaforum link Co-Authored-By: Dillon Skaggs <[email protected]>
Should be good |
Is there a different interior you could use for these examples (maybe the biker hideout right next to the casino, iirc it has entity sets too). I could not get these examples to work. |