Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Div zero? #3783

Open
QiAnXinCodeSafe opened this issue Sep 10, 2024 · 0 comments
Open

Div zero? #3783

QiAnXinCodeSafe opened this issue Sep 10, 2024 · 0 comments

Comments

@QiAnXinCodeSafe
Copy link

Hi all,
This is Qianxin CodeSafe Team, we found a suspicious div-zero, at

m_sAdaptiveQuantParam.iAverMotionTextureIndexToDeltaQp = iAverMotionTextureIndexToDeltaQp / iMbTotalNum;

in the maco used at
iAverageMotionIndex = WELS_DIV_ROUND64 (iAverageMotionIndex * AQ_INT_MULTIPLY, iMbTotalNum);

and
iAverageTextureIndex = WELS_DIV_ROUND64 (iAverageTextureIndex * AQ_INT_MULTIPLY, iMbTotalNum);

which is defined at
#define WELS_DIV_ROUND64(x,y) ((int64_t)((y)==0?((x)/((y)+1)):(((y)/2+(x))/(y))))

the second argument y of macro WELS_DIV_ROUND64 may be zero.
which means iMbTotalNum may be zero.
so at

m_sAdaptiveQuantParam.iAverMotionTextureIndexToDeltaQp = iAverMotionTextureIndexToDeltaQp / iMbTotalNum;

while dived by iMbTotalNum, a check against zero should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant