Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agency property does not account for None values #3210

Open
rachidatecs opened this issue Dec 10, 2024 · 0 comments · May be fixed by #3213
Open

Agency property does not account for None values #3210

rachidatecs opened this issue Dec 10, 2024 · 0 comments · May be fixed by #3213
Assignees
Labels
bug Something that isn't working as intended dev pulled in pulled into a sprint after sprint planning

Comments

@rachidatecs
Copy link
Contributor

Current Behavior

If an Agency does not exist, the property converted_federal_agency in the domainInformation model will cause an error that causes admin/domains to return a 500

This issue was already handled for domainRequests.

Expected Behavior

If an agency does not exist, the domains list should still return a 302 and the record for the domain with the missing federal agency should resolve. Federal agency should show as None, or empty.

Steps to Reproduce

  1. This is reproducible on the DK sandbox, which contains a large dataset with records that trigger this condition.

Environment

No response

Additional Context

The fix should match the pattern on domainRequests (or the pattern on domainRequests should be revised to match the fix implemented for domainInformation)

Issue Links

Relates to #2852

@rachidatecs rachidatecs added the bug Something that isn't working as intended label Dec 10, 2024
@rachidatecs rachidatecs moved this from 👶 New to 🍦 Backlog in .gov Product Board Dec 10, 2024
@CocoByte CocoByte self-assigned this Dec 10, 2024
@CocoByte CocoByte linked a pull request Dec 10, 2024 that will close this issue
32 tasks
@lizpearl lizpearl added dev pulled in pulled into a sprint after sprint planning labels Dec 10, 2024
@lizpearl lizpearl moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working as intended dev pulled in pulled into a sprint after sprint planning
Projects
Status: 🎯 Ready
Development

Successfully merging a pull request may close this issue.

3 participants