Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No content of GraphEditor.h and another headers #2

Open
gucio321 opened this issue Sep 12, 2024 · 6 comments
Open

No content of GraphEditor.h and another headers #2

gucio321 opened this issue Sep 12, 2024 · 6 comments

Comments

@gucio321
Copy link
Contributor

content from here is not generated: https://github.com/CedricGuillemet/ImGuizmo/blob/822be7b44c37dbe98d328739ebe0d5a1ea87ecfc/GraphEditor.h

@sonoro1234
Copy link
Contributor

sonoro1234 commented Sep 12, 2024

I gave GraphEditor a try running https://github.com/CedricGuillemet/ImGuizmo/blob/822be7b44c37dbe98d328739ebe0d5a1ea87ecfc/bin/ImGuizmoSample.exe but didnt like it.
Have you tried?

in cimgui there are cimnodes and cimnodes_r

You can see examples in ocornut/imgui#306 (comment)

@gucio321
Copy link
Contributor Author

Have you tried?

generally I tried to add it as a header in generator.lua but got issue about #incldue <C++Library>.
Maybe generator should use g++ to analyze code?
Also, ImGuizmo has more headers e.g. ImCurveEdit and ImGradient. would be nice to have these functions wrapped...

@sonoro1234
Copy link
Contributor

I mean trying https://github.com/CedricGuillemet/ImGuizmo/blob/822be7b44c37dbe98d328739ebe0d5a1ea87ecfc/bin/ImGuizmoSample.exe just to see how the widgets work so that you know which ones you like and which ones not.

After that it is also useful to read https://github.com/CedricGuillemet/ImGuizmo/blob/822be7b44c37dbe98d328739ebe0d5a1ea87ecfc/example/main.cpp to see if the api is good for your needs.

@gucio321
Copy link
Contributor Author

https://github.com/CedricGuillemet/ImGuizmo/blob/822be7b44c37dbe98d328739ebe0d5a1ea87ecfc/bin/ImGuizmoSample.exe just to see how the widgets work so that you know which ones you like and which ones not.

To be honest I didn't try that as I'm on linux and .exe doesn't sound like something I'd like to use 😄

fortunately that worked with wine for me 😄

After that it is also useful to read https://github.com/CedricGuillemet/ImGuizmo/blob/822be7b44c37dbe98d328739ebe0d5a1ea87ecfc/example/main.cpp to see if the api is good for your needs.

In perspective of cimgui-go I didn't consider what I would like to use but what users would ever want to use and in my view, the more functions is added, the wider use-cases may be satisfied.

@sonoro1234
Copy link
Contributor

in cimgui there are cimnodes and cimnodes_r

Did you compare?

@sonoro1234
Copy link
Contributor

sonoro1234 commented Sep 13, 2024

Uncomenting lines 152 and 153 on generator.lua you will get GraphEditor.h parsed. It includes vector which is a C++ header and needs g++ instead of gcc.

Compared with cimnodes and cimnodes_r I dont see it as a convinient addition

Also, virtual members from Delegate are not appropiate for C binding, function callbacks would be fine instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants