Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number issues #70

Open
khinsen opened this issue Sep 3, 2024 · 2 comments
Open

Version number issues #70

khinsen opened this issue Sep 3, 2024 · 2 comments

Comments

@khinsen
Copy link
Contributor

khinsen commented Sep 3, 2024

In ciel.asd, the version is defined as "0.2-202408-QL202310". Upon loading, ASDF complains that this is not a version number to its liking. As a consequence, the ASDF system object for ciel has version set to nil.

In scripting.lisp, I see (defparameter *ciel-version* "0.1" "Read from .asd or version.lisp-expr file.").

Proposal:

  • use an ASDF-compatible version number in ciel.asd
  • in scripting.lisp, use (defparameter *ciel-version* (asdf:component-version (asdf:find-system :ciel)))
@vindarel
Copy link
Contributor

vindarel commented Sep 3, 2024

As a consequence, the ASDF system object for ciel has version set to nil

ah, didn't notice, thanks.

use an ASDF-compatible version number in ciel.asd

yeah I went with an esoteric version number. I wanted to infer that there is both a ciel version and a version of the base Quicklisp dist it ships libraries from. In the future it is very likely we will release new CIEL binaries, when our code didn't change, but the libraries were updated.

WDYT?

in scripting.lisp, use (defparameter ciel-version (asdf:component-version (asdf:find-system :ciel)))

maybe even at readtime with #. (or we test thoroughly on another machine, asdf has been picky with me on other machines already).

@khinsen
Copy link
Contributor Author

khinsen commented Sep 3, 2024

Versioning ciel is indeed a bit tricky. From a user's perpective, my dream would be to have all dependency versions frozen for each ciel version. So ciel 2.0 would have the exact same dependencies on all machines. But that would make it impossible to install via plain Quicklisp. I would require Qlot, but even with Qlot I wouldn't know how to handle the dependencies that are downloaded directly as local projects.

Another idea: make a ciel-specific Quicklisp distribution, much like Ultralisp. Update it whenever you increase the ciel version number.

vindarel added a commit that referenced this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants