Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Regex for scrobbling EPs and Singles that does not affect normal album titles #888

Closed
4 tasks done
RegorForgot opened this issue Dec 28, 2024 · 4 comments
Closed
4 tasks done

Comments

@RegorForgot
Copy link

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have checked that the correct behavior occurs on Apple Music Web (if applicable).
  • I have verified that my issue is with a supported version and that it is with the desktop app (Support for other areas can be found in our Discord / on the appropriate repo).

How did you download Cider?

itch.io

Operating System

Windows 11

Commit Hash

No response

Build Timestamp

No response

Describe the Bug

The scrobbling album extension remover removes items after a " - ", including if they are part of the actual album name. Please note that this only occurs on Apple Music if the thing being played is an EP or a Single. Hence a Regex can be used to detect these specific cases that occur only at the end of the EP/Single name, something similar to the below:

- (Single|EP)$

This will only return a match if the above items are found within the album name.

Steps to Reproduce

  1. Enable Remove Album Extensions in the Connectivity tab under Last.fm settings
  2. Attempt to listen to an album which has a dash as part of its normal name - for example "Aril Brikha - Deeparture in Time - Revisited". Cider will attempt to scrobble this album without the " - Revisited" at the end of the name (which is definitely part of the album name).

Anything else?

No response

@cider-collective
Copy link

Hello @RegorForgot 👋

We really appreciate you taking the time to report this issue, please double check your issue to make sure you are clear and concise in your description. This will help us to help you as quickly as possible.

We'd like to ask you be patient and we will get back to you as soon as we can.

In the meantime, take a look at our FAQs which may answer your question.

Thanks again and we hope you enjoy the app! 😃

@RegorForgot RegorForgot changed the title Add Regex for scrobbling EPs and Singles that does not ruin normal album titles Add Regex for scrobbling EPs and Singles that does not affect normal album titles Dec 28, 2024
@cryptofyre
Copy link
Member

I’ll look into it.

@coredev-uk
Copy link
Contributor

We do already operate this way. Our current replace method uses .replace(/ - Single| - EP/g, '') Which operates in the same way, so not sure what you're on about.

@coredev-uk
Copy link
Contributor

nvm, we had that in one place, but the main one used a wildcard regex.

Fixed with https://github.com/ciderapp/citadel/commit/0f6dd4ac7f4f17bcbb97999533802a68edc382a6

@github-project-automation github-project-automation bot moved this from Backlog 📖 to Completed 🚀 in Cider - Bug Reports Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed 🚀
Development

No branches or pull requests

3 participants