Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ShapeDecoration #5

Open
riccardocescon opened this issue Nov 18, 2022 · 4 comments
Open

Support ShapeDecoration #5

riccardocescon opened this issue Nov 18, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@riccardocescon
Copy link

Seems like inset is not working while using ShapeDecoration.
The inset is always disabled

@ghost
Copy link

ghost commented Nov 19, 2022

Hello ! Thanks a lot for this feedback.

Currently the library only supports BoxDecoration. I'll investigate the possibility of supporting ShapeDecoration and get back to you. 👀

@ghost ghost self-assigned this Nov 19, 2022
@ghost ghost added the enhancement New feature or request label Nov 19, 2022
@ghost ghost changed the title Inset not working on ShapeDecoration Support ShapeDecoration Nov 19, 2022
@ghost
Copy link

ghost commented Nov 23, 2022

I think it's possible, but I don't know how expensive it will be in terms of performance. I think it will be fine, though.

I'm going to try to take the time to do that in the next two or three weeks. It's a little more complex to do than the BoxDecoration.

@riccardocescon
Copy link
Author

I see, thank you for adding this feature!

@ghost ghost added this to the v2.0.0 milestone Nov 23, 2022
@ghost
Copy link

ghost commented May 24, 2023

I won't be able to implement this feature myself after all, I can't find the time and motivation. 😔

I'll leave the issue open though, in case I find the motivation in the future or in case someone wants to contribute.

@ghost ghost removed this from the v2.0.0 milestone May 24, 2023
@ghost ghost added the help wanted Extra attention is needed label May 24, 2023
@ghost ghost removed their assignment Jan 18, 2024
@chitochi chitochi added the good first issue Good for newcomers label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants