@ss141309 test_daemon()/test_waitsig() should be called when the socket has been created.
The following page provides more information about the ZDTM API: https://criu.org/ZDTM_API

Ideally, the test should fail if the patch that adds support for ICMP sockets has not been applied.

@rst0git do you have an idea why I am not able to create an ICMP socket in the zdtm test suite?

#include "zdtmtst.h"
#include <unistd.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <netinet/ip_icmp.h>
#include <arpa/inet.h>
#include <sys/time.h>
#include <netdb.h>

int main(int argc, char **argv)
{
  int sock;
  test_init(argc, argv);

  sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_ICMP);
	if (sock < 0) {
		pr_perror("Can't create socket");
		return 1;
	}

	test_daemon();
	test_waitsig();

        close(sock);
	pass();
	return 0;
}

I run the test like this and get the output:

ss141309@fedora:~/criu/test$ sudo ./zdtm.py run --ignore-taint -a
[sudo] password for ss141309: 
userns is supported
The kernel is tainted: '12289'
Skipping zdtm/lib/groups (manual run only)
Skipping zdtm/static/conntracks (manual run only)
=== Run 3/3 ================ zdtm/static/socket_icmp
====================== Run zdtm/static/socket_icmp in ns =======================
 DEP       socket_icmp.d
 CC        socket_icmp.o
 LINK      socket_icmp
Start test
./socket_icmp --pidfile=socket_icmp.pid --outfile=socket_icmp.out
The test failed (0, 1)
make: *** [Makefile:504: socket_icmp.pid] Error 1
 Test zdtm/static/socket_icmp FAIL at ['make', '--no-print-directory', '-C', 'zdtm/static', 'socket_icmp.pid'] 
Test output: ================================
10:23:46.792:     4: ERR: socket_icmp.c:25: Can't create socket (errno = 13 (Permission denied))
10:23:46.792:     3: ERR: test.c:320: Test exited unexpectedly with code 1

 <<< ================================
##################################### FAIL #####################################

ICMP sockets probably require CAP_NET_RAW. You need to add the suid flag for this test. Here is an example: https://github.com/checkpoint-restore/criu/blob/criu-dev/test/zdtm/static/socket-raw.desc

@avagin using ICMP protocol with SOCK_DGRAM allows it to be run rootless and without requiring CAP_NET_RAW, also even if I add an suid flag in the desc file, the test fails.

Is this a problem with my net.ipv4.ping_group_range variable? It is set to '0 2147483647', therefore the program should have no problem running unprivileged ICMP sockets, this is evident when I run the test manually

make cleanout
sudo make socket_icmp
make socket_icmp.pid
// Then C-R
make socket_icmp.out

The test passes with no problem

@avagin I was also able to reproduce the error locally.

socket(AF_INET, SOCK_DGRAM, IPPROTO_ICMP) can be used for non-privileged ICMP. This works when used outside ZDTM. However, the ZDTM environment causes socket() to fail with Permission denied even when suid flag is set.

Is this a problem with my net.ipv4.ping_group_range variable?

The test still fails when net.ipv4.ping_group_range is set to 0 2147483647

All zdtm tests are running in separate (new) network namespaces. We have two places where test namespaces are created:

• test/zdtm_ct.c
• test/zdtm/lib/ns.c

In both cases, we need to set net.ipv4.ping_group_range. BTW, the net.ipv4.ping_group_range sysctl value should be C/R-ed.