Skip to content

Commit 1e933dc

Browse files
committed
Makefile: cleanup test targets and comment
1 parent b844005 commit 1e933dc

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

Makefile

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
MAKEFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST)))
22
MAKEFILE_DIR := $(dir $(MAKEFILE_PATH))
33

4+
# TODO: include internal/benchtest Makefile
5+
46
# Test options
57
GO ?= go
68
GOBIN ?= $(MAKEFILE_DIR)/bin
@@ -47,15 +49,19 @@ yellow = $(shell { tput setaf 3 || tput AF 3; } 2>/dev/null)
4749
cyan = $(shell { tput setaf 6 || tput AF 6; } 2>/dev/null)
4850
term-reset = $(shell { tput sgr0 || tput me; } 2>/dev/null)
4951

52+
# Run tests and linters. If this passes then CI tests
53+
# should also pass.
5054
.PHONY: all
51-
all: test install
55+
all: install test vet golangci-lint testgenerate
5256

5357
# Install pre-commit hooks and download modules
5458
.PHONY: install
5559
install: pre-commit
5660
@go mod download
5761
@go install
5862

63+
# TODO: I don't think we need/want override here
64+
5965
# Run verbose tests
6066
testverbose: override GO_TEST_FLAGS += -v
6167

@@ -98,7 +104,7 @@ testgenerate: bin/gen
98104

99105
# Run all tests (slow)
100106
.PHONY: testall
101-
testall: exhaustive testskipped testgenerate calibrate
107+
testall: exhaustive testskipped testgenerate
102108

103109
# Install richgo
104110
bin/richgo:

0 commit comments

Comments
 (0)