Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier broken #203

Open
nic-w opened this issue Jun 22, 2021 · 1 comment
Open

Prettier broken #203

nic-w opened this issue Jun 22, 2021 · 1 comment
Labels
client side/development client sided/developmental purpose/request/feature/issue enhancement

Comments

@nic-w
Copy link
Contributor

nic-w commented Jun 22, 2021

Prettier has deprecated babylon and renamed to babel (see here).

Either version <1.16.0 can be specified in the package.json or .prettierrc can be updated to latest values

Also it looks like tabWidth 2 should be the default considering current code
@F9Alejandro
Copy link
Collaborator

F9Alejandro commented Jul 1, 2021 •
edited
Loading

Prettier is a client side code formatter that has no effect on the end product except for how it looks visually. I haven't had any issues with the formatting as I have been using a decent IDE. Notepad++ also works to help keep your lines organized.

If you want to fix it up for newer versions you are free to do so. It is not in the package.json for node to grab so it is entirely up to the end user if they want it or not.

@F9Alejandro F9Alejandro added client side/development client sided/developmental purpose/request/feature/issue enhancement labels Jul 1, 2021
agamswaroop619 added a commit to agamswaroop619/DiscordBot that referenced this issue Aug 6, 2023
@agamswaroop619
Prettier issue chalda#203 solved
f3334b3
Einarin added a commit that referenced this issue Sep 2, 2023
@agamswaroop619 @Einarin
Prettier issue #203 solved (#237)
041cf59 
* Prettier issue #203 solved

* Keep semi colons

Currently we've been keeping semi colons in this code base, so making the prettier config reflect that.

---------

Co-authored-by: Johnny Dickinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client side/development client sided/developmental purpose/request/feature/issue enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@F9Alejandro @nic-w