Fix parse of unix timestamp with more than ns precision (influxdata#5826)

Author: danielnelson

internal/internal.go

@@ -348,25 +348,18 @@ func ParseTimestamp(timestamp interface{}, format string) (time.Time, error) {
 // format = "unix_ns": epoch is assumed to be in nanoseconds and can come as number or string. Cannot have a decimal part.
 func ParseTimestampWithLocation(timestamp interface{}, format string, location string) (time.Time, error) {
 	timeInt, timeFractional := int64(0), int64(0)
-	timeEpochStr, ok := timestamp.(string)
-	var err error
 
-	if !ok {
-		timeEpochFloat, ok := timestamp.(float64)
-		if !ok {
-			return time.Time{}, fmt.Errorf("time: %v could not be converted to string nor float64", timestamp)
-		}
-		intPart, frac := math.Modf(timeEpochFloat)
-		timeInt, timeFractional = int64(intPart), int64(frac*1e9)
-	} else {
-		splitted := regexp.MustCompile("[.,]").Split(timeEpochStr, 2)
+	switch ts := timestamp.(type) {
+	case string:
+		var err error
+		splitted := regexp.MustCompile("[.,]").Split(ts, 2)
 		timeInt, err = strconv.ParseInt(splitted[0], 10, 64)
 		if err != nil {
 			loc, err := time.LoadLocation(location)
 			if err != nil {
 				return time.Time{}, fmt.Errorf("location: %s could not be loaded as a location", location)
 			}
-			return time.ParseInLocation(format, timeEpochStr, loc)
+			return time.ParseInLocation(format, ts, loc)
 		}
 
 		if len(splitted) == 2 {
@@ -380,7 +373,15 @@ func ParseTimestampWithLocation(timestamp interface{}, format string, location s
 				return time.Time{}, err
 			}
 		}
+	case int64:
+		timeInt = ts
+	case float64:
+		intPart, frac := math.Modf(ts)
+		timeInt, timeFractional = int64(intPart), int64(frac*1e9)
+	default:
+		return time.Time{}, fmt.Errorf("time: %v could not be converted to string nor float64", timestamp)
 	}
+
 	if strings.EqualFold(format, "unix") {
 		return time.Unix(timeInt, timeFractional).UTC(), nil
 	} else if strings.EqualFold(format, "unix_ms") {

plugins/parsers/csv/parser.go

@@ -225,29 +225,25 @@ outer:
 // to the format.
 func parseTimestamp(timeFunc func() time.Time, recordFields map[string]interface{},
 	timestampColumn, timestampFormat string,
-) (metricTime time.Time, err error) {
-	metricTime = timeFunc()
-
+) (time.Time, error) {
 	if timestampColumn != "" {
 		if recordFields[timestampColumn] == nil {
-			err = fmt.Errorf("timestamp column: %v could not be found", timestampColumn)
-			return
+			return time.Time{}, fmt.Errorf("timestamp column: %v could not be found", timestampColumn)
 		}
 
-		tStr := fmt.Sprintf("%v", recordFields[timestampColumn])
-
 		switch timestampFormat {
 		case "":
-			err = fmt.Errorf("timestamp format must be specified")
-			return
+			return time.Time{}, fmt.Errorf("timestamp format must be specified")
 		default:
-			metricTime, err = internal.ParseTimestamp(tStr, timestampFormat)
+			metricTime, err := internal.ParseTimestamp(recordFields[timestampColumn], timestampFormat)
 			if err != nil {
-				return
+				return time.Time{}, err
 			}
+			return metricTime, err
 		}
 	}
-	return
+
+	return timeFunc(), nil
 }
 
 // SetDefaultTags set the DefaultTags

plugins/parsers/csv/parser_test.go

@@ -5,6 +5,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/influxdata/telegraf"
 	"github.com/influxdata/telegraf/metric"
 	"github.com/influxdata/telegraf/testutil"
 	"github.com/stretchr/testify/require"
@@ -322,3 +323,30 @@ func TestParseStream(t *testing.T) {
 			DefaultTime(),
 		), metric)
 }
+
+func TestTimestampUnixFloatPrecision(t *testing.T) {
+	p := Parser{
+		MetricName:      "csv",
+		ColumnNames:     []string{"time", "value"},
+		TimestampColumn: "time",
+		TimestampFormat: "unix",
+		TimeFunc:        DefaultTime,
+	}
+	data := `1551129661.95456123352050781250,42`
+
+	expected := []telegraf.Metric{
+		testutil.MustMetric(
+			"csv",
+			map[string]string{},
+			map[string]interface{}{
+				"value": 42,
+				"time":  1551129661.954561233,
+			},
+			time.Unix(1551129661, 954561233),
+		),
+	}
+
+	metrics, err := p.Parse([]byte(data))
+	require.NoError(t, err)
+	testutil.RequireMetricsEqual(t, expected, metrics)
+}